Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(25)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 1157313006: DevTools: extract common inspector bindigns code into InspectorWrapper (Closed)

Created:
4 years, 11 months ago by yurys
Modified:
4 years, 11 months ago
Reviewers:
sof, alph, sergeyv, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, arv+blink, vivekg_samsung, vivekg, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, blink-reviews-bindings_chromium.org, devtools-reviews_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, oilpan-reviews
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: extract common inspector bindigns code into InspectorWrapper BUG=466631 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196583

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+209 lines, -173 lines) Patch
M Source/bindings/core/v8/custom/V8InjectedScriptManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
A Source/bindings/core/v8/inspector/InspectorWrapper.h View 1 chunk +88 lines, -0 lines 0 comments Download
A Source/bindings/core/v8/inspector/InspectorWrapper.cpp View 1 chunk +67 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8InjectedScriptHost.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8InjectedScriptHost.cpp View 17 chunks +28 lines, -85 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8JavaScriptCallFrame.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/inspector/V8JavaScriptCallFrame.cpp View 1 3 chunks +17 lines, -78 lines 0 comments Download
M Source/bindings/core/v8/v8.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
yurys
4 years, 11 months ago (2015-06-05 13:43:25 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157313006/1
4 years, 11 months ago (2015-06-05 13:44:57 UTC) #4
sergeyv
lgtm
4 years, 11 months ago (2015-06-05 14:59:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157313006/20001
4 years, 11 months ago (2015-06-05 15:01:29 UTC) #8
sof
Will follow up on this one Oilpan-wise once it lands.
4 years, 11 months ago (2015-06-05 15:52:24 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-06-05 15:58:59 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196583

Powered by Google App Engine
This is Rietveld 408576698