Remove VisitedLink dependency on rest of chrome

chrome/browser/visitedlink/visitedlink_delegate.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_VISITEDLINK_VISITEDLINK_DELEGATE_H_
+#define CHROME_BROWSER_VISITEDLINK_VISITEDLINK_DELEGATE_H_
+
+#include <vector>

[tfarina, 2012/12/20 01:43:34]

you don't use this include in this header file.

[boliu, 2012/12/29 01:48:12]

Done.

+
+class GURL;
+
+namespace content {
+class BrowserContext;
+}  // namespace content
+
+// TODO(boliu): Comment
+class VisitedLinkDelegate {
+ public:
+  virtual bool IsEquivalentContext(content::BrowserContext* context1,
+                                   content::BrowserContext* context2) = 0;
+
+  class URLEnumerator {
+   public:
+    virtual void OnURL(const GURL& url) = 0;
+    virtual void OnComplete(bool success) = 0;
+   protected:

[tfarina, 2012/12/20 01:43:34]

add a blank line above.

[boliu, 2012/12/29 01:48:12]

Done.

+    virtual ~URLEnumerator() {}
+  };
+
+  virtual void RebuildTable(URLEnumerator* enumerator) = 0;

[joth, 2012/12/20 01:39:29]

virtual d'tor, DISALLOW_COPY etc.

[tfarina, 2012/12/20 01:43:34]

you don't need this subtle pattern of DISALLOW_COPY in an abstract class (aka
interface). Just let the subclass do this. But yeah, a protected virtual
destructor is missing though.

[boliu, 2012/12/29 01:48:12]

Done.

+};
+
+#endif  // CHROME_BROWSER_VISITEDLINK_VISITEDLINK_DELEGATE_H_