[Media Galleries] Move RemovableStorageInfo notifications to chrome namespace (part 2)

chrome/browser/system_monitor/removable_storage_notifications.h

Index: chrome/browser/system_monitor/removable_storage_notifications.h
diff --git a/chrome/browser/system_monitor/removable_storage_notifications.h b/chrome/browser/system_monitor/removable_storage_notifications.h
index 390cc1bd38463ac09f861ac30224de0ec58df3fb..6c12e46cba8e944027fab4e5da88b331b0f0b97c 100644
--- a/chrome/browser/system_monitor/removable_storage_notifications.h
+++ b/chrome/browser/system_monitor/removable_storage_notifications.h
@@ -9,7 +9,8 @@
 #include "base/observer_list_threadsafe.h"
 #include "base/string16.h"
 #include "base/synchronization/lock.h"
-#include "base/system_monitor/system_monitor.h"
+
+class MediaGalleriesPrivateApiTest;
 
 namespace chrome {
 
@@ -47,7 +48,7 @@ class RemovableStorageNotifications {
   // TODO(gbillock): Change this method signature to use StorageInfo.

[Hongbo Min, 2013/01/20 03:41:19]

What I see is you have already changed the signature to use StorageInfo, am I
right?

[Greg Billock, 2013/01/22 20:00:39]

Done.

   virtual bool GetDeviceInfoForPath(
       const FilePath& path,
-      base::SystemMonitor::RemovableStorageInfo* device_info) const = 0;
+      StorageInfo* device_info) const = 0;
 
   // Returns the storage size of the device present at |location|. If the
   // device information is unavailable, returns zero.
@@ -62,6 +63,15 @@ class RemovableStorageNotifications {
  protected:
   RemovableStorageNotifications();
 
+  // TODO(gbillock): remove these friends by making the classes owned by the

[vandebo (ex-Chrome), 2013/01/18 18:42:58]

nit: I don't think you're going to fix the tests that way, and you don't need
to.  Move the TODO down to line 71?

[Greg Billock, 2013/01/22 20:00:39]

Done.

+  // platform-specific implementation.
+  friend class MediaFileSystemRegistryTest;
+  friend class ::MediaGalleriesPrivateApiTest;
+  friend class MediaStorageUtilTest;
+  friend class MediaTransferProtocolDeviceObserverLinux;
+  friend class PortableDeviceWatcherWin;
+  friend class VolumeMountWatcherWin;
+
   void ProcessAttach(const std::string& id,
                      const string16& name,
                      const FilePath::StringType& location);