Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2036)

Unified Diff: chrome/browser/system_monitor/portable_device_watcher_win.h

Issue 11573048: [Media Galleries] Move RemovableStorageInfo notifications to chrome namespace (part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make singleton pointer live in base class. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/system_monitor/portable_device_watcher_win.h
diff --git a/chrome/browser/system_monitor/portable_device_watcher_win.h b/chrome/browser/system_monitor/portable_device_watcher_win.h
index dca68cba6faa050b4407208ae733d85b70923d1a..1b9c4ddff7f8fa94048f11aee34e4a2d9d43d180 100644
--- a/chrome/browser/system_monitor/portable_device_watcher_win.h
+++ b/chrome/browser/system_monitor/portable_device_watcher_win.h
@@ -14,7 +14,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
#include "base/string16.h"
-#include "base/system_monitor/system_monitor.h"
+#include "chrome/browser/system_monitor/removable_storage_notifications.h"
namespace base {
class SequencedTaskRunner;
@@ -25,8 +25,8 @@ class FilePath;
namespace chrome {
// This class watches the portable device mount points and sends notifications
-// to base::SystemMonitor about the attached/detached media transfer protocol
-// (MTP) devices. This is a singleton class instantiated by
+// about the attached/detached media transfer protocol (MTP) devices.
+// This is a singleton class instantiated by
// RemovableDeviceNotificationsWindowWin. This class is created, destroyed and
// operates on the UI thread, except for long running tasks it spins off to a
// SequencedTaskRunner.
@@ -60,6 +60,7 @@ class PortableDeviceWatcherWin {
};
typedef std::vector<DeviceDetails> Devices;
+ // !!! change to take the device notifs as arg
vandebo (ex-Chrome) 2013/01/18 18:42:58 nit: TODO
Greg Billock 2013/01/22 20:00:39 Done. On 2013/01/18 18:42:58, vandebo wrote:
PortableDeviceWatcherWin();
virtual ~PortableDeviceWatcherWin();
@@ -68,7 +69,7 @@ class PortableDeviceWatcherWin {
void Init(HWND hwnd);
// Processes DEV_BROADCAST_DEVICEINTERFACE messages and triggers a
- // SystemMonitor notification if appropriate.
+ // notification if appropriate.
void OnWindowMessage(UINT event_type, LPARAM data);
private:
@@ -76,7 +77,7 @@ class PortableDeviceWatcherWin {
// Key: MTP device storage unique id.
// Value: Metadata for the given storage.
- typedef std::map<std::string, base::SystemMonitor::RemovableStorageInfo>
+ typedef std::map<std::string, RemovableStorageNotifications::StorageInfo>
MTPStorageMap;
// Key: MTP device plug and play ID string.

Powered by Google App Engine
This is Rietveld 408576698