Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: chrome/browser/media_gallery/media_file_system_registry.cc

Issue 11573048: [Media Galleries] Move RemovableStorageInfo notifications to chrome namespace (part 2) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make singleton pointer live in base class. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media_gallery/media_file_system_registry.cc
diff --git a/chrome/browser/media_gallery/media_file_system_registry.cc b/chrome/browser/media_gallery/media_file_system_registry.cc
index 412fedb462d8aac077a246a0bb13874c1bf88ce5..d169259edf13ec8ad3bd8d902f4f4f0052ae2430 100644
--- a/chrome/browser/media_gallery/media_file_system_registry.cc
+++ b/chrome/browser/media_gallery/media_file_system_registry.cc
@@ -17,7 +17,6 @@
#include "base/stl_util.h"
#include "base/string_number_conversions.h"
#include "base/string_util.h"
-#include "base/system_monitor/system_monitor.h"
#include "base/utf_string_conversions.h"
#include "base/values.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -28,6 +27,7 @@
#include "chrome/browser/prefs/pref_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/system_monitor/media_storage_util.h"
+#include "chrome/browser/system_monitor/removable_storage_notifications.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_paths.h"
#include "chrome/common/extensions/extension_constants.h"
@@ -46,7 +46,6 @@
#include "webkit/fileapi/file_system_types.h"
#include "webkit/fileapi/isolated_context.h"
-using base::SystemMonitor;
using content::BrowserThread;
using content::NavigationController;
using content::RenderProcessHost;
@@ -494,12 +493,13 @@ MediaGalleriesPreferences* MediaFileSystemRegistry::GetPreferences(
if (ContainsKey(extension_hosts_map_, profile))
return preferences;
- // SystemMonitor may be NULL in unit tests.
- SystemMonitor* system_monitor = SystemMonitor::Get();
- if (!system_monitor)
+ // RemovableStorageNotifications may be NULL in unit tests.
+ RemovableStorageNotifications* notifications =
+ RemovableStorageNotifications::GetInstance();
+ if (!notifications)
return preferences;
- std::vector<SystemMonitor::RemovableStorageInfo> existing_devices =
- system_monitor->GetAttachedRemovableStorage();
+ std::vector<RemovableStorageNotifications::StorageInfo>
+ existing_devices = notifications->GetAttachedStorage();
for (size_t i = 0; i < existing_devices.size(); i++) {
if (!MediaStorageUtil::IsMediaDevice(existing_devices[i].device_id))
continue;
@@ -511,11 +511,10 @@ MediaGalleriesPreferences* MediaFileSystemRegistry::GetPreferences(
}
void MediaFileSystemRegistry::OnRemovableStorageAttached(
- const std::string& id, const string16& name,
- const FilePath::StringType& location) {
+ const RemovableStorageNotifications::StorageInfo& info) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
- if (!MediaStorageUtil::IsMediaDevice(id))
+ if (!MediaStorageUtil::IsMediaDevice(info.device_id))
return;
for (ExtensionGalleriesHostMap::iterator profile_it =
@@ -523,12 +522,13 @@ void MediaFileSystemRegistry::OnRemovableStorageAttached(
profile_it != extension_hosts_map_.end();
++profile_it) {
MediaGalleriesPreferences* preferences = GetPreferences(profile_it->first);
- preferences->AddGallery(id, name, FilePath(), false /*not user added*/);
+ preferences->AddGallery(info.device_id, info.name, FilePath(),
+ false /*not user added*/);
}
}
void MediaFileSystemRegistry::OnRemovableStorageDetached(
- const std::string& id) {
+ const RemovableStorageNotifications::StorageInfo& info) {
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
// Since revoking a gallery in the ExtensionGalleriesHost may cause it
@@ -545,7 +545,7 @@ void MediaFileSystemRegistry::OnRemovableStorageDetached(
MediaGalleriesPreferences* preferences = GetPreferences(profile_it->first);
InvalidatedGalleriesInfo invalid_galleries_in_profile;
invalid_galleries_in_profile.pref_ids =
- preferences->LookUpGalleriesByDeviceId(id);
+ preferences->LookUpGalleriesByDeviceId(info.device_id);
for (ExtensionHostMap::const_iterator extension_host_it =
profile_it->second.begin();
@@ -649,17 +649,19 @@ class MediaFileSystemRegistry::MediaFileSystemContextImpl
MediaFileSystemRegistry::MediaFileSystemRegistry()
: file_system_context_(new MediaFileSystemContextImpl(this)) {
- // SystemMonitor may be NULL in unit tests.
- SystemMonitor* system_monitor = SystemMonitor::Get();
- if (system_monitor)
- system_monitor->AddDevicesChangedObserver(this);
+ // RemovableStorageNotifications may be NULL in unit tests.
+ RemovableStorageNotifications* notifications =
+ RemovableStorageNotifications::GetInstance();
+ if (notifications)
+ notifications->AddObserver(this);
}
MediaFileSystemRegistry::~MediaFileSystemRegistry() {
- // SystemMonitor may be NULL in unit tests.
- SystemMonitor* system_monitor = SystemMonitor::Get();
- if (system_monitor)
- system_monitor->RemoveDevicesChangedObserver(this);
+ // RemovableStorageNotifications may be NULL in unit tests.
+ RemovableStorageNotifications* notifications =
+ RemovableStorageNotifications::GetInstance();
+ if (notifications)
+ notifications->RemoveObserver(this);
#if defined(SUPPORT_MTP_DEVICE_FILESYSTEM)
DCHECK(mtp_device_delegate_map_.empty());
#endif

Powered by Google App Engine
This is Rietveld 408576698