Inline Doubles truncate and round.

tests/language/arithmetic_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Dart test program to test arithmetic operations.
 
 library arithmetic_test;
 import 'dart:math';
 
 class ArithmeticTest {
 
@@ skipping 19 matching lines @@
     // No exception allowed for parse double.
     double d = double.parse(str);
     try {
       var a = d.toInt();
       return false;
     } on UnsupportedError catch (e) {
       return true;
     }
   }
 
   static runOne() {

[Florian Schneider, 2013/01/11 09:49:30]

This is not directly related to your CL, but we need to make sure that all the
test cases here are actually hit in optimized state:

If this function deoptimizes repeatedly and the hard limit on the number of
deoptimizations is reached, we will never  execute the remaining optimized code
(after the last deoptimization point.

[srdjan, 2013/01/11 19:41:08]

I agree, suggestions?

     var a = 22;
     var b = 4;
     // Smi & smi.
     Expect.equals(26, a + b);
     Expect.equals(18, a - b);
     Expect.equals(88, a * b);
     Expect.equals(5, a ~/ b);
     Expect.equals(5.5, a / b);
     Expect.equals(2.0, 10 / 5);
     Expect.equals(2, a % b);
@@ skipping 224 matching lines @@
     Expect.equals(-3.0, (-2.6).round());
     Expect.equals(0.0, (0.0).round());
     Expect.equals(0.0, (0.1).round());
     Expect.equals(false, (0.0).round().isNegative);
     Expect.equals(false, (0.1).round().isNegative);
     Expect.equals(-0.0, (-0.0).round());
     Expect.equals(-0.0, (-0.3).round());
     Expect.equals(2.0, (2.1).round());
     Expect.equals(-2.0, (-2.1).round());
     Expect.equals(1.0, (0.5).round());
-    // TODO(floitsch): enable or adapt test, once we reached conclusion on
-    // b/4539188.
-    // Expect.equals(-0.0, (-0.5).round());
-    // TODO(srdjan): enable the following tests once isNegative works.
-    // Expect.equals(true, (-0.0).round().isNegative);
-    // Expect.equals(true, (-0.3).round().isNegative);
-    // Expect.equals(true, (-0.5).round().isNegative);
+    Expect.equals(0.0, (0.49999999999999994).round());
+    Expect.equals(-0.0, (-0.49999999999999994).round());
+    Expect.equals(-1.0, (-0.5).round());
+    Expect.equals(true, (-0.0).round().isNegative);
+    Expect.equals(true, (-0.3).round().isNegative);
+    Expect.equals(true, (-0.5).round().isNegative);
     Expect.equals(2.0, (1.5).round());
-    // TODO(floitsch): enable or adapt test, once we reached conclusion on
-    // b/4539188.
-    // Expect.equals(-1.0, (-1.5).round());
+    Expect.equals(-2.0, (-1.5).round());

[Florian Schneider, 2013/01/11 09:49:30]

Please also add another corner case (2^53-1) and -(2^53-1) to the test suite.


Expect.equals(9007199254740991, (9007199254740991).round());
Expect.equals(-9007199254740991, (-9007199254740991).round());

[srdjan, 2013/01/11 19:41:08]

Thanks, using 9007199254740991.0. 

     Expect.equals(1.0, (0.99).round());
 
     // -- toInt --.
     // Smi.
     Expect.equals(0, (0).toInt());
     Expect.equals(1, (1).toInt());
     Expect.equals(-1, (-1).toInt());
     // Type checks.
     { int i = (0).toInt(); }
     { int i = (1).toInt(); }
@@ skipping 118 matching lines @@
     for (int i = 0; i < 1500; i++) {
       runOne();
       testSmiDivDeopt();
     }
   }
 }
 
 main() {
   ArithmeticTest.testMain();
 }