Inline Doubles truncate and round.

runtime/vm/flow_graph_optimizer.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_optimizer.h"
 
 #include "vm/bit_vector.h"
 #include "vm/cha.h"
 #include "vm/flow_graph_builder.h"
 #include "vm/flow_graph_compiler.h"
@@ skipping 1210 matching lines @@
 
   if ((recognized_kind == MethodRecognizer::kIntegerToDouble) &&
       (class_ids[0] == kSmiCid)) {
     SmiToDoubleInstr* s2d_instr = new SmiToDoubleInstr(call);
     call->ReplaceWith(s2d_instr, current_iterator());
     // Pushed arguments are not removed because SmiToDouble is implemented
     // as a call.
     return true;
   }
 
-  if ((recognized_kind == MethodRecognizer::kDoubleToInteger) &&
-      (class_ids[0] == kDoubleCid)) {
-    AddCheckClass(call, call->ArgumentAt(0)->value()->Copy());
-    ASSERT(call->HasICData());
-    const ICData& ic_data = *call->ic_data();
-    Definition* d2i_instr = NULL;
-    if (ic_data.deopt_reason() == kDeoptDoubleToSmi) {
-      // Do not repeatedly deoptimize because result didn't fit into Smi.
-      d2i_instr = new DoubleToIntegerInstr(call->ArgumentAt(0)->value(), call);
-    } else {
-      // Optimistically assume result fits into Smi.
-      d2i_instr = new DoubleToSmiInstr(call->ArgumentAt(0)->value(), call);
+  if (class_ids[0] == kDoubleCid) {
+    if (recognized_kind == MethodRecognizer::kDoubleToInteger) {
+      AddCheckClass(call, call->ArgumentAt(0)->value()->Copy());
+      ASSERT(call->HasICData());
+      const ICData& ic_data = *call->ic_data();
+      Definition* d2i_instr = NULL;
+      if (ic_data.deopt_reason() == kDeoptDoubleToSmi) {
+        // Do not repeatedly deoptimize because result didn't fit into Smi.
+        d2i_instr = new DoubleToIntegerInstr(call->ArgumentAt(0)->value(),
+                                             call);
+      } else {
+        // Optimistically assume result fits into Smi.
+        d2i_instr = new DoubleToSmiInstr(call->ArgumentAt(0)->value(), call);
+      }
+      call->ReplaceWith(d2i_instr, current_iterator());
+      RemovePushArguments(call);
+      return true;
     }
-    call->ReplaceWith(d2i_instr, current_iterator());
-    RemovePushArguments(call);
-    return true;
+    if ((recognized_kind == MethodRecognizer::kDoubleTruncate) ||
+        (recognized_kind == MethodRecognizer::kDoubleRound)) {

[Florian Schneider, 2013/01/11 09:49:30]

You need to check if SSE 4.1 is supported here: CPUFeatures::sse4_1_supported())

[srdjan, 2013/01/11 19:48:21]

Done.

+      AddCheckClass(call, call->ArgumentAt(0)->value()->Copy());
+      DoubleToDoubleInstr* d2d_instr =
+          new DoubleToDoubleInstr(call->ArgumentAt(0)->value(),
+                                  call,
+                                  recognized_kind);
+      call->ReplaceWith(d2d_instr, current_iterator());
+      RemovePushArguments(call);
+      return true;
+    }
   }
 
   return false;
 }
 
 
 // Returns a Boolean constant if all classes in ic_data yield the same type-test
 // result and the type tests do not depend on type arguments. Otherwise return
 // Bool::null().
 RawBool* FlowGraphOptimizer::InstanceOfAsBool(const ICData& ic_data,
@@ skipping 2930 matching lines @@
   SetValue(instr, non_constant_);
 }
 
 
 void ConstantPropagator::VisitDoubleToSmi(DoubleToSmiInstr* instr) {
   // TODO(kmillikin): Handle conversion.
   SetValue(instr, non_constant_);
 }
 
 
+void ConstantPropagator::VisitDoubleToDouble(DoubleToDoubleInstr* instr) {
+  // TODO(kmillikin): Handle conversion.
+  SetValue(instr, non_constant_);
+}
+
+
 void ConstantPropagator::VisitConstant(ConstantInstr* instr) {
   SetValue(instr, instr->value());
 }
 
 
 void ConstantPropagator::VisitConstraint(ConstraintInstr* instr) {
   // Should not be used outside of range analysis.
   UNREACHABLE();
 }
 
@@ skipping 207 matching lines @@
 
   if (FLAG_trace_constant_propagation) {
     OS::Print("\n==== After constant propagation ====\n");
     FlowGraphPrinter printer(*graph_);
     printer.PrintBlocks();
   }
 }
 
 
 }  // namespace dart