Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: client/tools/buildbot_annotated_steps.py

Issue 11573003: Fix javahome for pub bots (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/tools/buildbot_annotated_steps.py
===================================================================
--- client/tools/buildbot_annotated_steps.py (revision 16022)
+++ client/tools/buildbot_annotated_steps.py (working copy)
@@ -204,18 +204,16 @@
#TODO(sigmund): remove this indirection once we update our bots
(name, version) = GetBuildInfo()
+ # The buildbot will set a BUILDBOT_JAVA_HOME relative to the dart
+ # root directory, set JAVA_HOME based on that.
+ FixJavaHome()
if name.startswith('dart-editor'):
- # TODO (danrubel) Fix dart-editor builds so that we can call FixJavaHome() before the build
- FixJavaHome()
status = ProcessTools('release', name, version)
elif name.startswith('pub-'):
status = ProcessBot(name, 'pub')
elif name.startswith('vm-android'):
status = ProcessBot(name, 'android')
else:
- # The buildbot will set a BUILDBOT_JAVA_HOME relative to the dart
- # root directory, set JAVA_HOME based on that.
- FixJavaHome()
status = ProcessBot(name, 'compiler')
if status:
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698