Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1157293004: Move cr build configuration outside output folders (Closed)

Created:
5 years, 6 months ago by petrcermak
Modified:
5 years, 6 months ago
Reviewers:
Sami
CC:
chromium-reviews, Miguel Garcia
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move cr build configuration outside output folders This patch moves the cr config files from: chromium_checkout/ .cr/ config.py (global client config) src/ out/ Release/ .cr/ config.py (build config for out/Release) To: chromium_checkout/ .cr/ client/ config.py (global client config) builds/ out/ Release/ config.py (build config for out/Release) By doing this, we will avoid the situation when clobber deletes the build config (see the associated tracking bug below). Note that cr will automatically migrate existing config files to the new directory structure. BUG=493023 Committed: https://crrev.com/3fb5c2d9a5922fd6bc4a0905f1eea9713fb2d0c6 Cr-Commit-Position: refs/heads/master@{#332613}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Address skyostil's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -7 lines) Patch
M tools/cr/cr/base/client.py View 1 5 chunks +62 lines, -7 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
petrcermak
Hi, please review this patch. Thanks, Petr
5 years, 6 months ago (2015-06-03 10:49:08 UTC) #3
Sami
Thanks, lgtm with a nit. https://codereview.chromium.org/1157293004/diff/20001/tools/cr/cr/base/client.py File tools/cr/cr/base/client.py (right): https://codereview.chromium.org/1157293004/diff/20001/tools/cr/cr/base/client.py#newcode89 tools/cr/cr/base/client.py:89: def _GetOldConfigDir(use_build_dir): nit: s/Old/Deprecated/ ...
5 years, 6 months ago (2015-06-03 12:49:14 UTC) #4
petrcermak
Thanks for your comments. Petr https://codereview.chromium.org/1157293004/diff/20001/tools/cr/cr/base/client.py File tools/cr/cr/base/client.py (right): https://codereview.chromium.org/1157293004/diff/20001/tools/cr/cr/base/client.py#newcode89 tools/cr/cr/base/client.py:89: def _GetOldConfigDir(use_build_dir): On 2015/06/03 ...
5 years, 6 months ago (2015-06-03 13:21:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157293004/40001
5 years, 6 months ago (2015-06-03 13:25:05 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 6 months ago (2015-06-03 14:28:13 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 14:28:56 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3fb5c2d9a5922fd6bc4a0905f1eea9713fb2d0c6
Cr-Commit-Position: refs/heads/master@{#332613}

Powered by Google App Engine
This is Rietveld 408576698