fix ENUM_CONSTANT suggestions

fix ENUM_CONSTANT suggestions

BUG=
R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/4224b9c0498d349afbc25819a4668fd9c446b12f

[danrubel, 2015-06-04 21:46:48]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[danrubel, 2015-06-04 21:46:48]

Enum constants were being suggested with element type FIELD, but now are
suggested with element type ENUM_CONSTANT as specified in the analysis server
API.

[scheglov, 2015-06-04 21:55:37]

LGTM

https://codereview.chromium.org/1157283004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol_server.dart (right):

https://codereview.chromium.org/1157283004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol_server.dart:111: ElementKind
newElementKind_fromEngine(engine.ElementKind kind) {
This function is always invoked for some "elementInstance.kind" in production,
so maybe we could merge it with newElementKind_fromEngineElement().

[danrubel, 2015-06-04 22:00:08]

https://codereview.chromium.org/1157283004/diff/1/pkg/analysis_server/lib/src...
File pkg/analysis_server/lib/src/protocol_server.dart (right):

https://codereview.chromium.org/1157283004/diff/1/pkg/analysis_server/lib/src...
pkg/analysis_server/lib/src/protocol_server.dart:111: ElementKind
newElementKind_fromEngine(engine.ElementKind kind) {
On 2015/06/04 21:55:37, scheglov wrote:
> This function is always invoked for some "elementInstance.kind" in production,
> so maybe we could merge it with newElementKind_fromEngineElement().

There are a number of tests for this method which I did not want to touch for
this CL, but yes, that would be a good next step.

[danrubel, 2015-06-04 22:01:10]

Committed patchset #2 (id:20001) manually as
4224b9c0498d349afbc25819a4668fd9c446b12f (presubmit successful).