Reland "Fixed a couple of failing DCHECK(has_pending_exception())."

Reland "Fixed a couple of failing DCHECK(has_pending_exception()). (patchset #1 id:1 of https://codereview.chromium.org/1151373002/ )"

BUG=chromium:491062
LOG=N

Committed: https://crrev.com/c984efe6e3d8a0c5ed61a6fdd27807c7962beffa
Cr-Commit-Position: refs/heads/master@{#28699}

[Igor Sheludko, 2015-05-27 14:33:56]

ishell@chromium.org changed reviewers:
+ yangguo@chromium.org

[Igor Sheludko, 2015-05-27 14:33:57]

PTAL

https://codereview.chromium.org/1157273002/diff/2/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1157273002/diff/2/src/isolate.cc#newcode855
src/isolate.cc:855: return Throw(heap()->undefined_value(), nullptr);
Maybe it is better to throw "stack overflow" instead. WDYT?

[Yang, 2015-05-29 11:04:52]

lgtm with a question.

https://codereview.chromium.org/1157273002/diff/2/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1157273002/diff/2/src/isolate.cc#newcode855
src/isolate.cc:855: return Throw(heap()->undefined_value(), nullptr);
On 2015/05/27 14:33:57, Igor Sheludko wrote:
> Maybe it is better to throw "stack overflow" instead. WDYT?

When does this actually happen?

[Igor Sheludko, 2015-05-29 11:14:43]

https://codereview.chromium.org/1157273002/diff/2/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/1157273002/diff/2/src/isolate.cc#newcode855
src/isolate.cc:855: return Throw(heap()->undefined_value(), nullptr);
On 2015/05/29 11:04:52, Yang wrote:
> On 2015/05/27 14:33:57, Igor Sheludko wrote:
> > Maybe it is better to throw "stack overflow" instead. WDYT?
> 
> When does this actually happen?

The test case attached calls %DebugGetLoadedScripts() when the stack is almost
over and the actual stack overflow could happen during bootstrapping when we
don't have the stack overflow exception boilerplate yet.
In offline discussion we agreed that it doesn't actually matter what to throw in
this case as we are failing to bootstrap anyway.

[Igor Sheludko, 2015-05-29 11:14:47]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2015-05-29 11:14:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1157273002/2

[commit-bot: I haz the power, 2015-05-29 11:37:17]

Committed patchset #2 (id:2)

[commit-bot: I haz the power, 2015-05-29 11:37:31]

Patchset 2 (id:??) landed as
https://crrev.com/c984efe6e3d8a0c5ed61a6fdd27807c7962beffa
Cr-Commit-Position: refs/heads/master@{#28699}