Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1157263003: Add vector_math and box2d as external Dart packages (Closed)

Created:
5 years, 6 months ago by Cutch
Modified:
5 years, 6 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, Aaron Boodman, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add vector_math and box2d as external Dart packages - Add vector_math and box2d packages as third-party DEPS - Minimally extend dart_pkg GN rule to support external packages - Add //third_party/dart-pkg build target to setup external packages in gen/dart-pkg R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/93cf2efbbe49d3134f2ec44a572e020963fc0fab

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -11 lines) Patch
M .gitignore View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M DEPS View 1 2 chunks +8 lines, -0 lines 0 comments Download
A build/ls.py View 1 chunk +31 lines, -0 lines 0 comments Download
M mojo/dart/embedder/BUILD.gn View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M mojo/public/dart/rules.gni View 5 chunks +24 lines, -4 lines 0 comments Download
A + third_party/dart-pkg/BUILD.gn View 1 2 1 chunk +11 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
abarth-chromium
https://codereview.chromium.org/1157263003/diff/1/mojo/dart/embedder/BUILD.gn File mojo/dart/embedder/BUILD.gn (right): https://codereview.chromium.org/1157263003/diff/1/mojo/dart/embedder/BUILD.gn#newcode49 mojo/dart/embedder/BUILD.gn:49: "//mojo/dart/third_party", Maybe move to //third_party/dart-pkg ?
5 years, 6 months ago (2015-06-02 17:01:11 UTC) #2
Cutch
https://codereview.chromium.org/1157263003/diff/1/mojo/dart/embedder/BUILD.gn File mojo/dart/embedder/BUILD.gn (right): https://codereview.chromium.org/1157263003/diff/1/mojo/dart/embedder/BUILD.gn#newcode49 mojo/dart/embedder/BUILD.gn:49: "//mojo/dart/third_party", On 2015/06/02 17:01:11, abarth wrote: > Maybe move ...
5 years, 6 months ago (2015-06-02 20:47:42 UTC) #3
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-02 21:07:14 UTC) #4
Cutch
5 years, 6 months ago (2015-06-02 21:09:29 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
93cf2efbbe49d3134f2ec44a572e020963fc0fab.

Powered by Google App Engine
This is Rietveld 408576698