Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1386)

Unified Diff: Source/devtools/front_end/network/NetworkLogView.js

Issue 1157263002: [DevTools] Improve UX of timeline column sort in Network panel. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Fixed review comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/devtools/front_end/network/networkLogView.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/network/NetworkLogView.js
diff --git a/Source/devtools/front_end/network/NetworkLogView.js b/Source/devtools/front_end/network/NetworkLogView.js
index df44004fc3b9e1a79ce2d02d5d811f2c744d3cf0..5276e3c3becca391fcdf368967ba10537f83befc 100644
--- a/Source/devtools/front_end/network/NetworkLogView.js
+++ b/Source/devtools/front_end/network/NetworkLogView.js
@@ -498,36 +498,44 @@ WebInspector.NetworkLogView.prototype = {
var option = createElement("option");
option.value = "startTime";
option.label = WebInspector.UIString("Timeline");
+ option.disabled = true;
timelineSorting.appendChild(option);
option = createElement("option");
option.value = "startTime";
- option.label = WebInspector.UIString("Start Time");
+ option.label = WebInspector.UIString("Timeline \u2013 Start Time");
+ option.sortOrder = WebInspector.DataGrid.Order.Ascending;
timelineSorting.appendChild(option);
option = createElement("option");
option.value = "responseTime";
- option.label = WebInspector.UIString("Response Time");
+ option.label = WebInspector.UIString("Timeline \u2013 Response Time");
+ option.sortOrder = WebInspector.DataGrid.Order.Ascending;
timelineSorting.appendChild(option);
option = createElement("option");
option.value = "endTime";
- option.label = WebInspector.UIString("End Time");
+ option.label = WebInspector.UIString("Timeline \u2013 End Time");
+ option.sortOrder = WebInspector.DataGrid.Order.Ascending;
timelineSorting.appendChild(option);
option = createElement("option");
option.value = "duration";
- option.label = WebInspector.UIString("Duration");
+ option.label = WebInspector.UIString("Timeline \u2013 Total Duration");
+ option.sortOrder = WebInspector.DataGrid.Order.Descending;
timelineSorting.appendChild(option);
option = createElement("option");
option.value = "latency";
- option.label = WebInspector.UIString("Latency");
+ option.label = WebInspector.UIString("Timeline \u2013 Latency");
+ option.sortOrder = WebInspector.DataGrid.Order.Descending;
timelineSorting.appendChild(option);
var header = this._dataGrid.headerTableHeader("timeline");
header.replaceChild(timelineSorting, header.firstChild);
+ header.createChild("div", "sort-order-icon-container").createChild("div", "sort-order-icon");
+ timelineSorting.selectedIndex = 1;
timelineSorting.addEventListener("click", function(event) { event.consume(); }, false);
timelineSorting.addEventListener("change", this._sortByTimeline.bind(this), false);
this._timelineSortSelector = timelineSorting;
@@ -607,7 +615,7 @@ WebInspector.NetworkLogView.prototype = {
var sortingFunction = this._sortingFunctions[value];
this._dataGrid.sortNodes(sortingFunction);
this._highlightNthMatchedRequestForSearch(this._updateMatchCountAndFindMatchIndex(this._currentMatchedRequestNode), false);
- this._dataGrid.markColumnAsSortedBy("timeline", WebInspector.DataGrid.Order.Ascending);
+ this._dataGrid.markColumnAsSortedBy("timeline", selectedOption.sortOrder);
},
_updateSummaryBar: function()
« no previous file with comments | « no previous file | Source/devtools/front_end/network/networkLogView.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698