Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1157263002: [DevTools] Improve UX of timeline column sort in Network panel. (Closed)

Created:
5 years, 6 months ago by dgozman
Modified:
5 years, 6 months ago
Reviewers:
paulirish, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[DevTools] Improve UX of timeline column sort in Network panel. BUG=462189 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196145

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fixed review comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M Source/devtools/front_end/network/NetworkLogView.js View 1 2 chunks +14 lines, -6 lines 0 comments Download
M Source/devtools/front_end/network/networkLogView.css View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
dgozman
Take a look please.
5 years, 6 months ago (2015-05-27 13:03:35 UTC) #2
paulirish
Some wording tweaks
5 years, 6 months ago (2015-05-27 15:54:17 UTC) #3
paulirish
https://codereview.chromium.org/1157263002/diff/1/Source/devtools/front_end/network/NetworkLogView.js File Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1157263002/diff/1/Source/devtools/front_end/network/NetworkLogView.js#newcode512 Source/devtools/front_end/network/NetworkLogView.js:512: option.label = WebInspector.UIString("Timeline \u2013 Response Time"); Response Start Time ...
5 years, 6 months ago (2015-05-27 15:54:29 UTC) #4
dgozman
Pavel, ping.
5 years, 6 months ago (2015-05-28 11:05:08 UTC) #5
pfeldman
lgtm
5 years, 6 months ago (2015-05-29 12:42:49 UTC) #6
dgozman
https://codereview.chromium.org/1157263002/diff/1/Source/devtools/front_end/network/NetworkLogView.js File Source/devtools/front_end/network/NetworkLogView.js (right): https://codereview.chromium.org/1157263002/diff/1/Source/devtools/front_end/network/NetworkLogView.js#newcode512 Source/devtools/front_end/network/NetworkLogView.js:512: option.label = WebInspector.UIString("Timeline \u2013 Response Time"); On 2015/05/27 15:54:29, ...
5 years, 6 months ago (2015-05-29 12:58:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157263002/20001
5 years, 6 months ago (2015-05-29 12:58:50 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 14:08:00 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196145

Powered by Google App Engine
This is Rietveld 408576698