Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 1157253007: Connect mojo:debugger to window_manager only when requested. (Closed)

Created:
5 years, 6 months ago by ppi
Modified:
5 years, 6 months ago
Reviewers:
qsr, abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Connect mojo:debugger to window_manager only when requested. This patch makes mojo:debugger automatically connect to window_manager only when run by skydb, so that running the debugger for tracing and profiling doesn't bring the side-effect of spawning window_manager. Note that we might in the future change this to make the connection to window_manager lazy when load() or reload() is requested, but this would require a more involved change to skydb. The way taken in this patch doesn't change the skydb codepath while enabling usage of debugger for interactive tracing / profiling. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/007b11a3f7742dd40ac20560d35ba37e7791d82b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -2 lines) Patch
M services/debugger/debugger.cc View 3 chunks +8 lines, -1 line 0 comments Download
M sky/tools/skydb View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ppi
Hi Ben, Adam, wdyt?
5 years, 6 months ago (2015-06-02 14:44:45 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-02 15:05:17 UTC) #3
ppi
5 years, 6 months ago (2015-06-02 15:40:09 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
007b11a3f7742dd40ac20560d35ba37e7791d82b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698