Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1157253002: Remove SVGTextLayoutEngine::m_pathLayoutBoxes (Closed)

Created:
5 years, 7 months ago by fs
Modified:
5 years, 7 months ago
Reviewers:
pdr., f(malita)
CC:
blink-reviews, krit, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove SVGTextLayoutEngine::m_pathLayoutBoxes Line boxes are added to this vector, and finalizeTransformMatrices() iterates through it. The latter will however never do anything for these line boxes, because layoutTextBoxes() is the only thing that adds boxes to the map that will cause finalizeTransformMatrices() to have an effect. BUG=486669 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195997

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M Source/core/layout/svg/SVGTextLayoutEngine.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/layout/svg/SVGTextLayoutEngine.cpp View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fs
Bombardement! [1] [1] https://www.youtube.com/watch?v=3m3ZkJTX1qY
5 years, 7 months ago (2015-05-27 14:39:02 UTC) #2
f(malita)
I'm not sure what m_pathLayoutBoxes' initial purpose was, but yeah - it certainly doesn't seem ...
5 years, 7 months ago (2015-05-27 14:55:01 UTC) #3
fs
On 2015/05/27 14:55:01, f(malita) wrote: > I'm not sure what m_pathLayoutBoxes' initial purpose was, but ...
5 years, 7 months ago (2015-05-27 15:04:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157253002/1
5 years, 7 months ago (2015-05-27 15:06:01 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 18:03:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195997

Powered by Google App Engine
This is Rietveld 408576698