Issue 1157243012: Fork theme to theme2 and use sky.Color types directly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1157243012: Fork theme to theme2 and use sky.Color types directly. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
Hixie

CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, Matt Perry, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+257 lines, -5 lines)			Patch
M	sky/examples/stocks2/lib/stock_app.dart	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	sky/sdk/BUILD.gn	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	sky/sdk/lib/framework/theme/colors.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
A	sky/sdk/lib/framework/theme2/colors.dart	View	1 chunk	+252 lines, -0 lines	0 comments	Download
A +	sky/sdk/lib/framework/theme2/shadows.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sky/sdk/lib/framework/theme2/typography.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	sky/sdk/lib/framework/theme2/view_configuration.dart	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Total messages: 4 (0 generated)

eseidel

5 years, 6 months ago (2015-06-03 22:22:15 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
024f025bea747a91f5b7e6529f33ed15ccb4ffa9 (presubmit successful).