Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1157213005: Add a Subzero variant of Chrome PNaCl error handling test. (Closed)

Created:
5 years, 6 months ago by jvoung (off chromium)
Modified:
5 years, 6 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Subzero variant of Chrome PNaCl error handling test. Make sure that subzero can also handle various pexes with a bad header. Test with a tiny fake .pexe (already had that test case) and a larger realistic nonfinalized pexe. The nonfinalized pexe requires streaming multiple chunks and so is able to tickle an error-reporting race condition (use-after-free) + possible deadlock. I tried it on subzero from last week and was able to tickle the crash. It should no longer tickle that bug this week unless there's a regression. The tiny version runs pretty quickly, but otherwise had not been crashing before. It merely returned an imprecise error message ("Some error occurred"), which should now be fixed too. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4163 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng Committed: https://crrev.com/89cda3776ecc975213ac4b626845deea417f977f Cr-Commit-Position: refs/heads/master@{#333769}

Patch Set 1 #

Patch Set 2 : add missing files and relax regex #

Total comments: 2

Patch Set 3 : make more explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -7 lines) Patch
M chrome/test/data/nacl/nacl_test_data.gyp View 1 2 1 chunk +7 lines, -1 line 0 comments Download
A + chrome/test/data/nacl/pnacl_error_handling/pnacl_bad_pexe_O0.nmf View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/nacl/pnacl_error_handling/pnacl_error_handling.html View 1 1 chunk +25 lines, -2 lines 0 comments Download
A + chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 1 chunk +9 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
jvoung (off chromium)
5 years, 6 months ago (2015-06-08 18:11:29 UTC) #2
Nick Bray (chromium)
LGTM w/ one question. https://codereview.chromium.org/1157213005/diff/20001/chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf File chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf (right): https://codereview.chromium.org/1157213005/diff/20001/chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf#newcode6 chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf:6: "url": "pnacl_errors_newlib_pnacl.pexe.debug" In what conditions ...
5 years, 6 months ago (2015-06-09 17:25:00 UTC) #3
jvoung (off chromium)
https://codereview.chromium.org/1157213005/diff/20001/chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf File chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf (right): https://codereview.chromium.org/1157213005/diff/20001/chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf#newcode6 chrome/test/data/nacl/pnacl_error_handling/pnacl_nonfinal_pexe_O0.nmf:6: "url": "pnacl_errors_newlib_pnacl.pexe.debug" On 2015/06/09 17:25:00, Nick Bray (chromium) wrote: ...
5 years, 6 months ago (2015-06-09 18:03:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157213005/40001
5 years, 6 months ago (2015-06-09 21:27:41 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
5 years, 6 months ago (2015-06-09 23:31:06 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157213005/40001
5 years, 6 months ago (2015-06-10 18:13:54 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 6 months ago (2015-06-10 18:59:18 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-10 19:00:24 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/89cda3776ecc975213ac4b626845deea417f977f
Cr-Commit-Position: refs/heads/master@{#333769}

Powered by Google App Engine
This is Rietveld 408576698