chrome/browser/extensions/extension_browsertest.cc - Issue 11572061: Create DeclarativeConditionSet, DeclarativeActionSet, and DeclarativeRule templates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browsertest.cc

Issue 11572061: Create DeclarativeConditionSet, DeclarativeActionSet, and DeclarativeRule templates (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/declarative_webrequest/webrequest_condition.h ('K') | « chrome/browser/extensions/api/web_request/web_request_api.cc ('k') | chrome/chrome_browser_extensions.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_browsertest.cc

diff --git a/chrome/browser/extensions/extension_browsertest.cc b/chrome/browser/extensions/extension_browsertest.cc

index f53505ae4635a58384c4718500f980e0dc01999f..9ec476de1ebaa1c37963117dd3cbbfbae217b332 100644

--- a/chrome/browser/extensions/extension_browsertest.cc

+++ b/chrome/browser/extensions/extension_browsertest.cc

@@ -589,6 +589,9 @@ void ExtensionBrowserTest::NavigateInRenderer(content::WebContents* contents,

&result));

ASSERT_TRUE(result);

observer.Wait();

+ EXPECT_EQ(&contents->GetController(),

+ content::Source<content::NavigationController>(observer.source()

+ ).ptr());

battre 2012/12/17 11:46:06 does this belong here?

Jeffrey Yasskin 2012/12/19 08:23:06 No. Thanks, reverted.

EXPECT_EQ(url, contents->GetController().GetLastCommittedEntry()->GetURL());

}