Issue 11572052: Don't report the gtest return code as a TestResult object.

Issue 11572052: Don't report the gtest return code as a TestResult object. (Closed)

Created:
8 years ago by frankf

Modified:
8 years ago

Reviewers:
craigdh, bulach, Yaron

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't report the gtest return code as a TestResult object. Fix some style issues. BUG=165529 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173555

Patch Set 2 : Rebased #

Total comments: 3

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -26 lines)			Patch
	M	build/android/pylib/test_package.py	View	1	2 chunks	+30 lines, -26 lines	3 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

craigdh

lgtm with nit. https://codereview.chromium.org/11572052/diff/2001/build/android/pylib/test_package.py File build/android/pylib/test_package.py (right): https://codereview.chromium.org/11572052/diff/2001/build/android/pylib/test_package.py#newcode130 build/android/pylib/test_package.py:130: re_fail = re.compile('\[ FAILED \] ?(.*)\r\n') ...

8 years ago (2012-12-14 23:10:47 UTC) #2

frankf

Ping. https://codereview.chromium.org/11572052/diff/2001/build/android/pylib/test_package.py File build/android/pylib/test_package.py (right): https://codereview.chromium.org/11572052/diff/2001/build/android/pylib/test_package.py#newcode130 build/android/pylib/test_package.py:130: re_fail = re.compile('\[ FAILED \] ?(.*)\r\n') There are ...

8 years ago (2012-12-17 20:09:28 UTC) #3

craigdh

https://codereview.chromium.org/11572052/diff/2001/build/android/pylib/test_package.py File build/android/pylib/test_package.py (right): https://codereview.chromium.org/11572052/diff/2001/build/android/pylib/test_package.py#newcode130 build/android/pylib/test_package.py:130: re_fail = re.compile('\[ FAILED \] ?(.*)\r\n') On 2012/12/17 20:09:28, ...

8 years ago (2012-12-17 20:24:09 UTC) #4

lgtm

I think Marcus is OOO

Expand Messages | Collapse Messages