Issue 11572044: Automatically retry the following URLFetchers when the network changes:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11572044: Automatically retry the following URLFetchers when the network changes: (Closed)

Created:
8 years ago by Joao da Silva

Modified:
8 years ago

Reviewers:
jochen (gone - plz use gerrit), Jói, Mattias Nissler (ping if slow)

CC:
chromium-reviews, Aaron Boodman, cbentzel+watch_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Automatically retry the following URLFetchers when the network changes: extensions_downloader.cc (extensions, retail mode AppPack) gaia_oauth_fetcher.cc gaia_oauth_client.cc device_management_service.cc (user/device policy fetches, auto-enrollment) All of these have been noticed to fail when network change notifications are sent, in particular on ChromeOS. TBR=jochen BUG=145021, 163710, 130602, chromium-os:16114 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173232

Patch Set 1 #

Patch Set 2 : Document the retry behavior #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -55 lines)			Patch
M	chrome/browser/extensions/updater/extension_downloader.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/net/gaia/gaia_oauth_fetcher.cc	View	1	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/app_pack_updater.h	View		5 chunks	+2 lines, -16 lines	0 comments	Download
M	chrome/browser/policy/app_pack_updater.cc	View		9 chunks	+3 lines, -39 lines	0 comments	Download
M	chrome/browser/policy/device_management_service.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	google_apis/gaia/gaia_oauth_client.cc	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

After https://codereview.chromium.org/11464028/ this can be landed to fix 3 bugs in one small CL! Please ...

8 years ago (2012-12-14 15:31:28 UTC) #1

Mattias Nissler (ping if slow)

LGTM. Looking forward to this problem becoming a thing of the past.

8 years ago (2012-12-14 15:52:34 UTC) #2

Jói

8 years ago (2012-12-14 15:53:08 UTC) #3

LGTM for google_apis with a request: Document the reason for the 3 retries right
there in the code, and reference the bug.

Expand Messages | Collapse Messages