Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 11572041: [content shell] implement additional URL handling methods of the WebTestDelegate (Closed)

Created:
8 years ago by jochen (gone - plz use gerrit)
Modified:
8 years ago
Reviewers:
marja
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org
Visibility:
Public.

Description

[content shell] implement additional URL handling methods of the WebTestDelegate Those callbacks are not yet used, but are required for the TestRunner BUG=111316 R=marja@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173435

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -30 lines) Patch
M content/shell/shell_content_renderer_client.cc View 3 chunks +5 lines, -25 lines 0 comments Download
M content/shell/shell_messages.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/shell/webkit_test_controller.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/webkit_test_controller.cc View 1 2 chunks +6 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M content/shell/webkit_test_runner.cc View 1 5 chunks +46 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
8 years ago (2012-12-14 13:34:12 UTC) #1
jochen (gone - plz use gerrit)
On 2012/12/14 13:34:12, jochen wrote: compare https://code.google.com/searchframe#OAMlx_jo-ck/src/webkit/support/webkit_support.cc&exact_package=chromium&q=webkit_support.cc%20localfiletodatA&type=cs&l=696
8 years ago (2012-12-14 13:39:35 UTC) #2
marja
lgtm
8 years ago (2012-12-14 13:57:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11572041/1
8 years ago (2012-12-14 14:02:51 UTC) #4
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
8 years ago (2012-12-14 15:59:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/11572041/1
8 years ago (2012-12-14 17:01:58 UTC) #6
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests
8 years ago (2012-12-15 00:02:38 UTC) #7
commit-bot: I haz the power
8 years ago (2012-12-17 08:14:48 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698