Do not load extension system in the Profile import process.

chrome/browser/first_run/first_run_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/first_run/first_run.h"
 
 #include <shellapi.h>
 #include <shlobj.h>
 #include <windows.h>
 
@@ skipping 314 matching lines @@
   const CommandLine& cmdline = *CommandLine::ForCurrentProcess();
   CommandLine import_cmd(cmdline.GetProgram());
 
   const char* kSwitchNames[] = {
     switches::kUserDataDir,
     switches::kChromeFrame,
     switches::kCountry,
   };
   import_cmd.CopySwitchesFrom(cmdline, kSwitchNames, arraysize(kSwitchNames));
 
+  // Allow tests to introduce additional switches.
+  import_cmd.AppendArguments(first_run::GetExtraArgumentsForImportProcess(),

[sky, 2012/12/18 16:24:02]

Instead of this, can you mutate the command line after the browser test launches
but before import?

[tapted, 2012/12/19 00:07:53]

I haven't yet found a clean way to do that.. The problem was that if
"--as-browser" is not passed at this point for a test process, then
test_launcher.cc:LaunchTests() tries to restart all the tests, because
--gtest_filter is not included in kSwitchNames just above this line (and I don't
think I can get away with including it ;-). (also, with --gtest_filter, it
crosses the test sharding code paths, which I'm not sure it would like). So
currently only --as-browser is ever appended here (but there's scope for more if
further integration testing is done for the first-run import).

I looked at content::ChildProcessHost::GetChildPath(..CHILD_NORMAL) instead of
cmdline.GetProgram() [line 326 here], but it boils down the same thing, so also
tries to relaunch ./browser_tests from scratch and run all the tests.

Another option would be to include "--import" (and "--import-from-file") in the
list of flags in ShouldRunContentMain(), at
http://code.google.com/searchframe#OAMlx_jo-ck/src/content/public/test/test_l...
But I didn't see a current dependency in test_launcher.cc on
chrome/common/content_switches.h (nor c/b/profiles to get the IsImportProcess
helper I'm introducing).

Creating a duplicate kLaunchAsBrowser[] (.. or "--as-browser" literal) in
first_run_win.cc would also achieve the goal, but might be naughty (and I didn't
think #including test_launcher.h in first_run_win.cc would pass review/DEPS
either). But maybe that's the lesser evil..

Then, I've been poking around more in the test_launcher.cc and browser_tests
code paths, but I'm not seeing a way to hook back into a specific test in order
to mutate the command line, without passing --gtest_filter in the relaunch
command.

[sky, 2012/12/19 16:14:00]

What happens if you add --as-browser to your tests SetUpCommandLine?

+                             false);
+
   // Since ImportSettings is called before the local state is stored on disk
   // we pass the language as an argument.  GetApplicationLocale checks the
   // current command line as fallback.
   import_cmd.AppendSwitchASCII(switches::kLang,
                                g_browser_process->GetApplicationLocale());
 
   if (items_to_import) {
     import_cmd.AppendSwitchASCII(switches::kImport,
         EncodeImportParams(importer_type, items_to_import, skip_first_run_ui));
   }
@@ skipping 158 matching lines @@
 
 FilePath MasterPrefsPath() {
   // The standard location of the master prefs is next to the chrome binary.
   FilePath master_prefs;
   if (!PathService::Get(base::DIR_EXE, &master_prefs))
     return FilePath();
   return master_prefs.AppendASCII(installer::kDefaultMasterPrefs);
 }
 
 }  // namespace first_run