Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: chrome/browser/ui/bookmarks/bookmark_utils.h

Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: add unittest and codes for mac and gtk Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/bookmarks/bookmark_utils.h
diff --git a/chrome/browser/ui/bookmarks/bookmark_utils.h b/chrome/browser/ui/bookmarks/bookmark_utils.h
index e5d4e0c5f6a15c287447063c406c5eef60cbd365..0f7513e1ea2454f59d00713b3479dd00d5b9d693 100644
--- a/chrome/browser/ui/bookmarks/bookmark_utils.h
+++ b/chrome/browser/ui/bookmarks/bookmark_utils.h
@@ -27,16 +27,20 @@ namespace chrome {
// bookmarks that are of type url for folders in |nodes|. |initial_disposition|
// dictates how the first URL is opened, all subsequent URLs are opened as
// background tabs. |navigator| is used to open the URLs.
+// When |initial_disposition| is OFF_THE_RECORD, a node which can't be opened
sky 2012/12/14 17:41:12 Remove this sentence, it's an implementation detai
+// in incognito window, it is detected using |browser_context|, is not opened.
void OpenAll(gfx::NativeWindow parent,
content::PageNavigator* navigator,
const std::vector<const BookmarkNode*>& nodes,
- WindowOpenDisposition initial_disposition);
+ WindowOpenDisposition initial_disposition,
+ content::BrowserContext* browser_context);
// Convenience for OpenAll() with a single BookmarkNode.
void OpenAll(gfx::NativeWindow parent,
content::PageNavigator* navigator,
const BookmarkNode* node,
- WindowOpenDisposition initial_disposition);
+ WindowOpenDisposition initial_disposition,
+ content::BrowserContext* browser_context);
// Asks the user before deleting a non-empty bookmark folder.
bool ConfirmDeleteBookmarkNode(const BookmarkNode* node,

Powered by Google App Engine
This is Rietveld 408576698