chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc - Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: modify mac build failure Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/bookmarks/bookmark_utils.cc ('K') | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.cc ('k') | chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views_win.cc » ('j') | chrome/browser/ui/views/bookmarks/bookmark_context_menu_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

diff --git a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

index 524bec8a1fe77268bebe2107617b770a03568297..c8ed56560f33a3264f6c6fc3a144c399c028487e 100644

--- a/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

+++ b/chrome/browser/ui/views/bookmarks/bookmark_context_menu_controller_views.cc

@@ -69,7 +69,7 @@ void BookmarkContextMenuControllerViews::ExecuteCommand(int id) {

UserMetricsAction("BookmarkBar_ContextMenu_OpenAllIncognito"));

}

chrome::OpenAll(parent_widget_->GetNativeWindow(), navigator_,

- selection_, initial_disposition);

+ selection_, initial_disposition, profile_);

bookmark_utils::RecordBookmarkLaunch(bookmark_utils::LAUNCH_CONTEXT_MENU);

break;

}