chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc - Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: modify mac build failure Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

diff --git a/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc b/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

index 70db1460f6e61d77a7bc2be3b4f549f72f20e18b..cf2688d6aa72d959ddcd4c926d5e656890071eba 100644

--- a/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

+++ b/chrome/browser/ui/gtk/bookmarks/bookmark_menu_controller_gtk.cc

@@ -244,7 +244,8 @@ gboolean BookmarkMenuController::OnMenuButtonPressedOrReleased(

menu_item ? GetNodeFromMenuItem(menu_item) : NULL;

if (event->button == 2 && node && node->is_folder()) {

- chrome::OpenAll(parent_window_, page_navigator_, node, NEW_BACKGROUND_TAB);

+ chrome::OpenAll(parent_window_, page_navigator_, node, NEW_BACKGROUND_TAB,

+ browser_->profile());

gtk_menu_popdown(GTK_MENU(menu_));

return TRUE;

} else if (event->button == 3) {