chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm - Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: modify mac build failure Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

index fdf754a7141a1488d5718586b8ca6294409fed5d..a4b54eafba09399537b08525e0f0fa30047124d7 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.mm

@@ -2678,7 +2678,8 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {

- (void)openAll:(const BookmarkNode*)node

disposition:(WindowOpenDisposition)disposition {

[self closeFolderAndStopTrackingMenus];

- chrome::OpenAll([[self view] window], browser_, node, disposition);

+ chrome::OpenAll([[self view] window], browser_, node, disposition,

+ browser_->profile());

}

- (void)addButtonForNode:(const BookmarkNode*)node