chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc - Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

Issue 11572031: "Open All Bookmarks in Incognito Window" opens only valid URLs (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: modify mac build failure Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/bookmarks/bookmark_context_menu_controller.cc ('k') | chrome/browser/ui/bookmarks/bookmark_utils.h » ('j') | chrome/browser/ui/bookmarks/bookmark_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

diff --git a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

index 94b97955b09947fbc4add657448ddc3b96aa9910..71d23623638f09a210ced2cefee02dc16476fd3e 100644

--- a/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

+++ b/chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc

@@ -121,7 +121,7 @@ TEST_F(BookmarkContextMenuControllerTest, DeleteURL) {

// Tests open all on a folder with a couple of bookmarks.

TEST_F(BookmarkContextMenuControllerTest, OpenAll) {

const BookmarkNode* folder = model_->bookmark_bar_node()->GetChild(1);

- chrome::OpenAll(NULL, &navigator_, folder, NEW_FOREGROUND_TAB);

+ chrome::OpenAll(NULL, &navigator_, folder, NEW_FOREGROUND_TAB, NULL);

// Should have navigated to F1's child, but not F11's child.

ASSERT_EQ(static_cast<size_t>(1), navigator_.urls_.size());