Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(39)

Issue 1157203004: Revert 196501 "Oilpan: Make PersistentNode hold a raw pointer" (Closed)

Created:
4 years, 10 months ago by haraken
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews
Visibility:
Public.

Description

Revert 196501 "Oilpan: Make PersistentNode hold a raw pointer" Discussed offline, and realized that this step is not helpful to remove m_trace from PersistentNode. > Oilpan: Make PersistentNode hold a raw pointer > > This CL changes: > > class PersistentNode { }; > class PersistentBase : public PersistentNode { }; > class Persistent { > T* m_raw; > }; > class CrossThreadPersistent { > T* m_raw; > }; > > to: > > class PersistentNode { > void* m_raw; > }; > class PersistentBase : public PersistentNode { }; > class Persistent { }; > class CrossThreadPersistent { }; > > This is a preparation for tracing the m_raw from PersistentNode and thus > remove PersistentNode::m_trace in a follow-up CL. > > BUG=483380 > > Review URL: https://codereview.chromium.org/1159003006 TBR=haraken@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196637

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -79 lines) Patch
M trunk/Source/platform/heap/Handle.h View 32 chunks +67 lines, -79 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
haraken
4 years, 10 months ago (2015-06-07 23:53:19 UTC) #1
haraken
4 years, 10 months ago (2015-06-07 23:53:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r196637.

Powered by Google App Engine
This is Rietveld 408576698