Impelement InputDevice.firesTouchEvents

Source/core/input/InputDevice.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef InputDevice_h
+#define InputDevice_h
+
+#include "bindings/core/v8/ScriptWrappable.h"
+#include "core/CoreExport.h"
+#include "core/input/InputDeviceInit.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefCounted.h"
+
+namespace blink {
+
+class CORE_EXPORT InputDevice : public RefCountedWillBeGarbageCollectedFinalized<InputDevice>, public ScriptWrappable {

[tkent, 2015/06/04 00:00:47]

Can we make this GarbageCollectedFinalized<> instead of
RefCountedWillBeGarbageCollectedFinalized<>?

[lanwei, 2015/06/04 21:21:35]

Done.

[Rick Byers, 2015/06/10 20:37:05]

I've been wondering about this.  How do we decide when a new class should be
strictly an Oilpan type vs. a WillBe* type?  Perhaps the Oilpan docs
(https://www.chromium.org/blink/blink-gc) should be updated to talk about this -
it's very unclear for random contributors not too familiar with Oilpan to know
how new code should be written...

[tkent, 2015/06/10 22:50:03]

There are no clear rules.  However, new web-exposed classes should be
GarbageCollected or GarbageCollectedFinalized without WillBe.  All of
web-exposed classes will be on Oilpan heap in the near future, and oilpan-team
is trying to reduce the number classes with WillBe now.

+    DEFINE_WRAPPERTYPEINFO();
+
+public:
+    ~InputDevice();
+    static PassRefPtrWillBeRawPtr<InputDevice> create()
+    {
+        return adoptRefWillBeNoop(new InputDevice);
+    }
+
+    static PassRefPtrWillBeRawPtr<InputDevice> create(bool firesTouchEvents)
+    {
+        return adoptRefWillBeNoop(new InputDevice(firesTouchEvents));
+    }
+
+    static PassRefPtrWillBeRawPtr<InputDevice> create(
+        const InputDeviceInit& initializer)
+    {
+        return adoptRefWillBeNoop(new InputDevice(initializer));
+    }
+
+    bool firesTouchEvents() const { return m_firesTouchEvents; }
+
+    DEFINE_INLINE_TRACE() { }
+
+private:
+    InputDevice();

[tkent, 2015/06/04 00:00:47]

Can we unify three constructors into one?

[Rick Byers, 2015/06/04 13:55:29]

Yeah, perhaps we only want the InputDeviceInit flavor?  We could perhaps even
remove the other two 'create' methods too and rely on all callers explicitly
creating an InputDeviceInit object?

[lanwei, 2015/06/04 21:21:35]

I think it is better to keep the one with a bool argument at least, instead of
creating an InputDeviceInit object for it, easy to read. We can refactor it
later if needed.

+    InputDevice(bool);
+    InputDevice(const InputDeviceInit&);
+
+    // Whether this device dispatches touch events. This mainly lets developers
+    // avoid handling both touch and mouse events dispatched for a single user
+    // action.
+    bool m_firesTouchEvents;
+};
+
+} // namespace blink
+
+#endif // InputDevice_h