Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(28)

Issue 1157173002: IndexedDB: IDL and tests for IDBIndex.getAllKeys. (Closed)

Created:
4 years, 11 months ago by cmumford
Modified:
4 years, 11 months ago
Reviewers:
jsbell
CC:
blink-reviews, jsbell+idb_chromium.org, dgrogan, cmumford
Base URL:
https://chromium.googlesource.com/chromium/blink.git@idb-index-getallkeys
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

IndexedDB: IDL and tests for IDBIndex.getAllKeys. IDL definition, and tests for an experimental web platform feature to return all keys (specified by the range) for the given index. https://w3c.github.io/IndexedDB/#widl-IDBIndex-getAllKeys-IDBRequest-any-query-unsigned-long-count Part 2 of 2 BUG=488689 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196263

Patch Set 1 #

Patch Set 2 : Fixed expected output for global-interface-listing-compositor-worker-expected.txt #

Patch Set 3 : Added expected results for virtual layout test suites #

Patch Set 4 : Rewound stable/virtual expected and made getAllKeys experimental #

Messages

Total messages: 21 (10 generated)
cmumford
4 years, 11 months ago (2015-05-26 22:28:07 UTC) #2
jsbell
lgtm
4 years, 11 months ago (2015-05-27 06:06:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157173002/1
4 years, 11 months ago (2015-05-29 19:38:18 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/63964)
4 years, 11 months ago (2015-05-29 22:01:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157173002/20001
4 years, 11 months ago (2015-06-01 17:40:54 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/64213)
4 years, 11 months ago (2015-06-01 19:24:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157173002/40001
4 years, 11 months ago (2015-06-01 19:57:05 UTC) #15
cmumford
jsbell: Thought you might want to take a quick look before I press the CL ...
4 years, 11 months ago (2015-06-01 21:11:50 UTC) #17
jsbell
lgtm (sorry, missed the ping)
4 years, 11 months ago (2015-06-01 23:20:35 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157173002/60001
4 years, 11 months ago (2015-06-01 23:33:42 UTC) #20
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 00:51:57 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196263

Powered by Google App Engine
This is Rietveld 408576698