Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Unified Diff: sky/sdk/lib/framework/components2/icon.dart

Issue 1157163009: Make the Icon component use Image (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/framework/components2/icon_button.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/sdk/lib/framework/components2/icon.dart
diff --git a/sky/sdk/lib/framework/components2/icon.dart b/sky/sdk/lib/framework/components2/icon.dart
index ed4d5a78b02b00d91455908ce7837cb6015dccdd..85b957f2b95a51dd9be30b4b08537a521394be60 100644
--- a/sky/sdk/lib/framework/components2/icon.dart
+++ b/sky/sdk/lib/framework/components2/icon.dart
@@ -10,7 +10,7 @@ import '../rendering/box.dart';
const String kAssetBase = '/packages/sky/assets/material-design-icons';
class Icon extends Component {
- int size;
+ double size;
String type;
Icon({
@@ -27,12 +27,9 @@ class Icon extends Component {
category = parts[0];
subtype = parts[1];
}
- // TODO(jackson): Use a real image.
- return new Container(
- desiredSize: new sky.Size(size.toDouble(), size.toDouble()),
- decoration: new BoxDecoration(backgroundColor: const sky.Color(0xFFFF0000))
+ return new Image(
+ size: new sky.Size(size, size),
+ src: '${kAssetBase}/${category}/2x_web/ic_${subtype}_${size}dp.png'
);
- // return new Image(width: size, height: size,
- // src: '${kAssetBase}/${category}/2x_web/ic_${subtype}_${size}dp.png');
}
}
« no previous file with comments | « no previous file | sky/sdk/lib/framework/components2/icon_button.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698