Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 1157163009: Make the Icon component use Image (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
jackson
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make the Icon component use Image Even though Image doesn't yet know how to handle relative urls. TBR=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3cf774ea0f2cf57d1d7bea84ff0a21cfb2d0925e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -9 lines) Patch
M sky/sdk/lib/framework/components2/icon.dart View 2 chunks +4 lines, -7 lines 0 comments Download
M sky/sdk/lib/framework/components2/icon_button.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/lib/framework/components2/menu_item.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
eseidel
Committed patchset #1 (id:1) manually as 3cf774ea0f2cf57d1d7bea84ff0a21cfb2d0925e (presubmit successful).
5 years, 6 months ago (2015-06-03 22:42:39 UTC) #1
jackson
5 years, 6 months ago (2015-06-03 22:52:39 UTC) #2
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698