Issue 1157163009: Make the Icon component use Image

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1157163009: Make the Icon component use Image (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
jackson

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, abarth-chromium

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make the Icon component use Image Even though Image doesn't yet know how to handle relative urls. TBR=jackson@google.com Committed: https://chromium.googlesource.com/external/mojo/+/3cf774ea0f2cf57d1d7bea84ff0a21cfb2d0925e

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -9 lines)			Patch
M	sky/sdk/lib/framework/components2/icon.dart	View	2 chunks	+4 lines, -7 lines	0 comments	Download
M	sky/sdk/lib/framework/components2/icon_button.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/sdk/lib/framework/components2/menu_item.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

eseidel

Committed patchset #1 (id:1) manually as 3cf774ea0f2cf57d1d7bea84ff0a21cfb2d0925e (presubmit successful).

5 years, 6 months ago (2015-06-03 22:42:39 UTC) #1

Message was sent while issue was closed.

lgtm