Issue 1157123003: Run V8 in predictable mode for pdfium_test

Issue 1157123003: Run V8 in predictable mode for pdfium_test (Closed)

Created:
5 years, 6 months ago by jochen (gone - plz use gerrit)

Modified:
5 years, 6 months ago

Reviewers:
Tom Sepez, kcc2

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Run V8 in predictable mode for pdfium_test This won't post tasks to the background threads BUG=none R=kcc@chromium.org, tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/cafa3fd96e850acbfa2633009b873b8ecb7aee5f

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	samples/pdfium_test.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
	M	testing/embedder_test.cpp	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 7 (0 generated)

Tom Sepez

RS LGTM. Thanks for keeping PDFium up-to-date with V8. Is there a specific version of ...

5 years, 6 months ago (2015-05-28 16:02:59 UTC) #3

Tom Sepez

Wait a minute. What about the same code sequence in testing/embedder_test.cpp?

5 years, 6 months ago (2015-05-28 16:31:25 UTC) #4

jochen (gone - plz use gerrit)

On 2015/05/28 at 16:31:25, tsepez wrote: > Wait a minute. What about the same code ...

5 years, 6 months ago (2015-05-28 17:30:59 UTC) #5

jochen (gone - plz use gerrit)

Committed patchset #3 (id:40001) manually as cafa3fd96e850acbfa2633009b873b8ecb7aee5f (presubmit successful).

5 years, 6 months ago (2015-05-29 08:22:38 UTC) #6

jochen (gone - plz use gerrit)

5 years, 6 months ago (2015-05-29 11:10:00 UTC) #7

Message was sent while issue was closed.

this doesn't need a specific V8 version, --predictable is supported since a very
long time