Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(937)

Unified Diff: pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart

Issue 1157113004: add enum suggestions (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: merge Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
diff --git a/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart b/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
index 77c43f03f2e9415d26eeb2cdd38a3793adfdc997..e46a7717c7cecf2e5b2b77d66f40ea9517a5e2bc 100644
--- a/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
+++ b/pkg/analysis_server/test/services/completion/local_reference_contributor_test.dart
@@ -4,7 +4,9 @@
library test.services.completion.dart.local;
-import 'package:analysis_server/src/protocol_server.dart';
+import 'package:analysis_server/src/protocol.dart' as protocol
+ show Element, ElementKind;
+import 'package:analysis_server/src/protocol.dart' hide Element, ElementKind;
import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
import 'package:analysis_server/src/services/completion/local_reference_contributor.dart';
import 'package:test_reflective_loader/test_reflective_loader.dart';
@@ -98,9 +100,9 @@ class LocalReferenceContributorTest extends AbstractSelectorSuggestionTest {
CompletionSuggestion cs = assertSuggest(name,
csKind: CompletionSuggestionKind.INVOCATION, relevance: relevance);
expect(cs.returnType, returnType != null ? returnType : 'dynamic');
- Element element = cs.element;
+ protocol.Element element = cs.element;
expect(element, isNotNull);
- expect(element.kind, equals(ElementKind.LOCAL_VARIABLE));
+ expect(element.kind, equals(protocol.ElementKind.LOCAL_VARIABLE));
expect(element.name, equals(name));
expect(element.parameters, isNull);
expect(element.returnType, returnType != null ? returnType : 'dynamic');
@@ -113,9 +115,9 @@ class LocalReferenceContributorTest extends AbstractSelectorSuggestionTest {
CompletionSuggestion cs = assertSuggest(name,
csKind: CompletionSuggestionKind.INVOCATION, relevance: relevance);
expect(cs.returnType, returnType != null ? returnType : 'dynamic');
- Element element = cs.element;
+ protocol.Element element = cs.element;
expect(element, isNotNull);
- expect(element.kind, equals(ElementKind.PARAMETER));
+ expect(element.kind, equals(protocol.ElementKind.PARAMETER));
expect(element.name, equals(name));
expect(element.parameters, isNull);
expect(element.returnType,
@@ -462,6 +464,22 @@ void main() {
assertSuggestLabel('foo');
}
+ test_enum() {
+ addTestSource('enum E { one, two } main() {^}');
+ expect(computeFast(), isTrue);
+ assertSuggestEnum('E');
+ assertNotSuggested('one');
+ assertNotSuggested('two');
+ }
+
+ test_enum_deprecated() {
+ addTestSource('@deprecated enum E { one, two } main() {^}');
+ expect(computeFast(), isTrue);
+ assertSuggestEnum('E', isDeprecated: true);
+ assertNotSuggested('one');
+ assertNotSuggested('two');
+ }
+
test_function_parameters_mixed_required_and_named() {
addTestSource('''
void m(x, {int y}) {}

Powered by Google App Engine
This is Rietveld 408576698