add enum suggestions

pkg/analysis_server/test/services/completion/completion_test_util.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.completion.util;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/analysis_server.dart';
 import 'package:analysis_server/src/protocol.dart' as protocol
@@ skipping 47 matching lines @@
   void addTestSource(String content) {
     expect(completionOffset, isNull, reason: 'Call addTestUnit exactly once');
     completionOffset = content.indexOf('^');
     expect(completionOffset, isNot(equals(-1)), reason: 'missing ^');
     int nextOffset = content.indexOf('^', completionOffset + 1);
     expect(nextOffset, equals(-1), reason: 'too many ^');
     content = content.substring(0, completionOffset) +
         content.substring(completionOffset + 1);
     testSource = addSource(testFile, content);
     cache = new DartCompletionCache(context, testSource);
-    AnalysisServer server = new AnalysisServerMock(searchEngine: searchEngine, resourceProvider: provider);
+    AnalysisServer server = new AnalysisServerMock(
+        searchEngine: searchEngine, resourceProvider: provider);
     request = new DartCompletionRequest(
         server, context, testSource, completionOffset, cache);
   }
 
   void assertHasNoParameterInfo(CompletionSuggestion suggestion) {
     expect(suggestion.parameterNames, isNull);
     expect(suggestion.parameterTypes, isNull);
     expect(suggestion.requiredParameterCount, isNull);
     expect(suggestion.hasNamedParameters, isNull);
   }
@@ skipping 466 matching lines @@
 abstract class AbstractSelectorSuggestionTest extends AbstractCompletionTest {
 
   /**
    * Assert that the ImportedReferenceContributor uses cached results
    * to produce identical suggestions to the original set of suggestions.
    */
   void assertCachedCompute(_) {
     // Subclasses override
   }
 
+  CompletionSuggestion assertSuggestEnum(String completion,
+      {bool isDeprecated: false}) {
+    CompletionSuggestion suggestion =
+        assertSuggest(completion, isDeprecated: isDeprecated);
+    expect(suggestion.isDeprecated, isDeprecated);
+    expect(suggestion.element.kind, protocol.ElementKind.ENUM);
+    return suggestion;
+  }
+
+  CompletionSuggestion assertSuggestEnumConst(String completion,
+      {bool isDeprecated: false}) {
+    CompletionSuggestion suggestion =
+        assertSuggest(completion, isDeprecated: isDeprecated);
+    expect(suggestion.isDeprecated, isDeprecated);
+    // TODO(danrubel) : Perhaps should be protocol.ElementKind.ENUM_CONST
+    // but element model represents them as FIELD
+    expect(suggestion.element.kind, protocol.ElementKind.FIELD);

[Paul Berry, 2015/05/29 17:55:57]

Should this be protocol.ElementKind.ENUM_CONSTANT instead of ElementKind.FIELD?

[danrubel, 2015/06/01 04:26:56]

Yes. See comment above code. Need to investigate whether we want ENUM_CONSTANT
to match API or FIELD to match engine element model. Will address in subsequent
CL.

[Paul Berry, 2015/06/01 12:45:59]

Oops.  Not sure how I missed the comment.  Thanks!

[danrubel, 2015/06/04 21:48:14]

https://codereview.chromium.org/1157283004/

+    return suggestion;
+  }
+
   CompletionSuggestion assertSuggestImportedClass(String name,
       {CompletionSuggestionKind kind: CompletionSuggestionKind.INVOCATION,
       int relevance: DART_RELEVANCE_DEFAULT, String importUri}) {
     return assertNotSuggested(name);
   }
 
   CompletionSuggestion assertSuggestImportedConstructor(String name,
       {int relevance: DART_RELEVANCE_DEFAULT, String importUri}) {
     return assertNotSuggested(name);
   }
@@ skipping 3781 matching lines @@
       assertNotSuggested('bar2');
       assertNotSuggested('_B');
       assertSuggestLocalClass('Y');
       assertSuggestLocalClass('C');
       assertSuggestLocalVariable('f', null);
       assertNotSuggested('x');
       assertNotSuggested('e');
     });
   }
 }