add enum suggestions

pkg/analysis_server/lib/src/services/completion/local_suggestion_builder.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.suggestion.builder.local;
 
 import 'package:analysis_server/src/protocol.dart' as protocol
     show Element, ElementKind;
 import 'package:analysis_server/src/protocol.dart' hide Element, ElementKind;
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analyzer/src/generated/ast.dart';
 import 'package:analyzer/src/generated/scanner.dart';
 
 const DYNAMIC = 'dynamic';
 
 final TypeName NO_RETURN_TYPE = new TypeName(
     new SimpleIdentifier(new StringToken(TokenType.IDENTIFIER, '', 0)), null);
 
 /**
  * Create a new protocol Element for inclusion in a completion suggestion.
  */
 protocol.Element createElement(protocol.ElementKind kind, SimpleIdentifier id,
-    {String parameters, TypeName returnType, bool isAbstract: false,
-    bool isDeprecated: false}) {
+    {String parameters, TypeName returnType, SimpleIdentifier enumName,
+    bool isAbstract: false, bool isDeprecated: false}) {
   String name = id != null ? id.name : '';
   int flags = protocol.Element.makeFlags(
       isAbstract: isAbstract,
       isDeprecated: isDeprecated,
       isPrivate: Identifier.isPrivateName(name));
+  String typeName = enumName != null ? enumName.name : nameForType(returnType);

[Paul Berry, 2015/05/29 17:55:57]

It's not clear to me why this is necessary.  Won't nameForType do the right
thing for enums?

[danrubel, 2015/06/01 04:26:56]

Oops. That's left over from an earlier refactoring and should have been removed.
Good catch!

   return new protocol.Element(kind, name, flags,
-      parameters: parameters, returnType: nameForType(returnType));
+      parameters: parameters, returnType: typeName);
 }
 
 /**
  * Create a new suggestion for the given field.
  * Return the new suggestion or `null` if it could not be created.
  */
 CompletionSuggestion createFieldSuggestion(
     FieldDeclaration fieldDecl, VariableDeclaration varDecl) {
   bool deprecated = isDeprecated(fieldDecl) || isDeprecated(varDecl);
   TypeName type = fieldDecl.fields.type;
   return createSuggestion(
       varDecl.name, deprecated, DART_RELEVANCE_LOCAL_FIELD, type,
       classDecl: fieldDecl.parent,
       element: createElement(protocol.ElementKind.FIELD, varDecl.name,
           returnType: type, isDeprecated: deprecated));
 }
 
 /**
  * Create a new suggestion based upon the given information.
  * Return the new suggestion or `null` if it could not be created.
  */
 CompletionSuggestion createSuggestion(SimpleIdentifier id, bool isDeprecated,
-    int defaultRelevance, TypeName returnType,
-    {ClassDeclaration classDecl, protocol.Element element}) {
+    int defaultRelevance, TypeName returnType, {ClassDeclaration classDecl,
+    SimpleIdentifier enumName, protocol.Element element}) {
   if (id == null) {
     return null;
   }
   String completion = id.name;
   if (completion == null || completion.length <= 0 || completion == '_') {
     return null;
   }
   CompletionSuggestion suggestion = new CompletionSuggestion(
       CompletionSuggestionKind.INVOCATION,
       isDeprecated ? DART_RELEVANCE_LOW : defaultRelevance, completion,
       completion.length, 0, isDeprecated, false,
-      returnType: nameForType(returnType), element: element);
+      returnType: enumName != null ? enumName.name : nameForType(returnType),

[Paul Berry, 2015/05/29 17:55:57]

Same question here.

[danrubel, 2015/06/01 04:26:56]

As above, old unused code. Removed.

+      element: element);
   if (classDecl != null) {
     SimpleIdentifier classId = classDecl.name;
     if (classId != null) {
       String className = classId.name;
       if (className != null && className.length > 0) {
         suggestion.declaringType = className;
       }
     }
   }
   return suggestion;
@@ skipping 31 matching lines @@
   String name = id.name;
   if (name == null || name.length <= 0) {
     return DYNAMIC;
   }
   TypeArgumentList typeArgs = type.typeArguments;
   if (typeArgs != null) {
     //TODO (danrubel) include type arguments
   }
   return name;
 }