build/secondary/tools/grit/grit_rule.gni - Issue 1157113003: GN build: don't use "" for grit input.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/secondary/tools/grit/grit_rule.gni

Issue 1157113003: GN build: don't use "" for grit input. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/secondary/tools/grit/grit_rule.gni

diff --git a/build/secondary/tools/grit/grit_rule.gni b/build/secondary/tools/grit/grit_rule.gni

index 3f22123993acbdeb3d3b9af06ff3b425c300b12d..a84ff1367dc0b908b99e56d30be055ece5cb8202 100644

--- a/build/secondary/tools/grit/grit_rule.gni

+++ b/build/secondary/tools/grit/grit_rule.gni

@@ -313,7 +313,10 @@ template("grit") {

} else {

resource_ids = grit_resource_id_file

}

- grit_inputs += [ resource_ids ] # Script depends on ID file.

+ if (resource_ids != "") {

+ # Script depends on ID file. Don't depend on "" if it's the empty string.

cjhopman 2015/05/28 18:40:44 s/on "" if/on resource_ids if/ ? Sentence is kinda

+ grit_inputs += [ resource_ids ]

+ }

if (defined(invoker.output_dir)) {

output_dir = invoker.output_dir

« no previous file with comments | « no previous file | no next file » | no next file with comments »