Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1157113003: GN build: don't use "" for grit input. (Closed)

Created:
5 years, 6 months ago by brettw
Modified:
5 years, 6 months ago
Reviewers:
cjhopman
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN build: don't use "" for grit input. If a grit target specifies a resource_ids file of "" (this has specific meaning documented in the grit rule), don't set the empty string as an input to the grit action. The only time this comes up is in the java_strings_grd template. Committed: https://crrev.com/af43f9f780b5fcca30faef007745306827d69c23 Cr-Commit-Position: refs/heads/master@{#331869}

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M build/secondary/tools/grit/grit_rule.gni View 1 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
brettw
5 years, 6 months ago (2015-05-28 17:04:47 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157113003/1
5 years, 6 months ago (2015-05-28 17:05:29 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-05-28 17:36:59 UTC) #6
cjhopman
lgtm https://codereview.chromium.org/1157113003/diff/1/build/secondary/tools/grit/grit_rule.gni File build/secondary/tools/grit/grit_rule.gni (right): https://codereview.chromium.org/1157113003/diff/1/build/secondary/tools/grit/grit_rule.gni#newcode317 build/secondary/tools/grit/grit_rule.gni:317: # Script depends on ID file. Don't depend ...
5 years, 6 months ago (2015-05-28 18:40:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157113003/20001
5 years, 6 months ago (2015-05-28 21:55:03 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-05-28 22:28:44 UTC) #11
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 22:29:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/af43f9f780b5fcca30faef007745306827d69c23
Cr-Commit-Position: refs/heads/master@{#331869}

Powered by Google App Engine
This is Rietveld 408576698