Issue 11571065: cc: Move occlusion tests to layer_tree_host_unittest_occlusion.cc

Issue 11571065: cc: Move occlusion tests to layer_tree_host_unittest_occlusion.cc (Closed)

Created:
8 years ago by danakj

Modified:
8 years ago

Reviewers:
jamesr, enne (OOO)

CC:
chromium-reviews, cc-bugs_chromium.org, piman, backer

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

cc: Move occlusion tests to layer_tree_host_unittest_occlusion.cc While moving the tests, I also split them up into separate classes/test cases to make the tests more clear and easy to read/change in the future. These tests also now use the real commit flow instead of inventing their own. R=enne,jamesr Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174064

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : nits #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+479 lines, -327 lines)			Patch
M	cc/cc_tests.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/layer_tree_host_unittest.cc	View		1 chunk	+0 lines, -327 lines	0 comments	Download
A	cc/layer_tree_host_unittest_occlusion.cc	View	1 2	1 chunk	+476 lines, -0 lines	0 comments	Download
M	cc/test/layer_tree_test_common.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jamesr

lgtm https://codereview.chromium.org/11571065/diff/4001/cc/layer_tree_host_unittest_occlusion.cc File cc/layer_tree_host_unittest_occlusion.cc (right): https://codereview.chromium.org/11571065/diff/4001/cc/layer_tree_host_unittest_occlusion.cc#newcode96 cc/layer_tree_host_unittest_occlusion.cc:96: layer->setAnchorPoint(gfx::PointF(0, 0)); gfx::PointF() or gfx::PointF(0.0f, 0.0f) please https://codereview.chromium.org/11571065/diff/4001/cc/layer_tree_host_unittest_occlusion.cc#newcode148 ...

8 years ago (2012-12-19 22:41:01 UTC) #2

danakj

8 years ago (2012-12-19 23:29:17 UTC) #3

Thanks :)

I assume doubles should have .0 suffix as well then.. so updated them too.

https://codereview.chromium.org/11571065/diff/4001/cc/layer_tree_host_unittes...
File cc/layer_tree_host_unittest_occlusion.cc (right):

https://codereview.chromium.org/11571065/diff/4001/cc/layer_tree_host_unittes...
cc/layer_tree_host_unittest_occlusion.cc:96:
layer->setAnchorPoint(gfx::PointF(0, 0));
On 2012/12/19 22:41:01, jamesr wrote:
> gfx::PointF() or gfx::PointF(0.0f, 0.0f) please

Done.

https://codereview.chromium.org/11571065/diff/4001/cc/layer_tree_host_unittes...
cc/layer_tree_host_unittest_occlusion.cc:148: gfx::PointF(0, 0), gfx::Size(200,
200), true);
On 2012/12/19 22:41:01, jamesr wrote:
> use 0.0f, etc, for float literals

Done.

Expand Messages | Collapse Messages