Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 1157103002: Fixing size_t -> int truncation in //net/quic/spdy_utils.cc (Closed)

Created:
5 years, 6 months ago by markbrand
Modified:
5 years, 6 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing size_t -> int truncation in //net/quic/spdy_utils.cc Trivial change altering length from int to size_t; since this variable is initialised from a size_t, and passed as a parameter to two functions that accept a size_t parameter. BUG=488553 Committed: https://crrev.com/f2415b13846f8217550257e85d3cb0130ddff197 Cr-Commit-Position: refs/heads/master@{#332370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M net/quic/spdy_utils.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
markbrand
eroman@, figured if you are going to be doing some work on 488553 I'd try ...
5 years, 6 months ago (2015-05-26 15:27:59 UTC) #2
eroman
lgtm
5 years, 6 months ago (2015-05-26 16:42:23 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157103002/1
5 years, 6 months ago (2015-06-02 09:28:03 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 6 months ago (2015-06-02 11:35:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1157103002/1
5 years, 6 months ago (2015-06-02 11:41:48 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-02 11:45:02 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 11:45:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2415b13846f8217550257e85d3cb0130ddff197
Cr-Commit-Position: refs/heads/master@{#332370}

Powered by Google App Engine
This is Rietveld 408576698