Issue 11571016: Only unbind a Graphics2D on destruction when we're actually bound.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11571016: Only unbind a Graphics2D on destruction when we're actually bound. (Closed)

Created:
8 years ago by brettw

Modified:
8 years ago

Reviewers:
bbudge, Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Only unbind a Graphics2D on destruction when we're actually bound. Previously if you made a new Graphics2D, bound it, and deleted the previous one, the first one would blindly unbind the current graphics 2D context in its destructor, which leaves you with a blank page. BUG=164302 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=173181

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -5 lines)			Patch
	M	content/renderer/pepper/pepper_graphics_2d_host.cc	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
	M	webkit/plugins/ppapi/ppb_graphics_2d_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

lgtm I have tested patch and it resolved the issue.

8 years ago (2012-12-13 23:44:30 UTC) #2

bbudge

8 years ago (2012-12-14 00:24:26 UTC) #3

lgtm

https://codereview.chromium.org/11571016/diff/1/content/renderer/pepper/peppe...
File content/renderer/pepper/pepper_graphics_2d_host.cc (right):

https://codereview.chromium.org/11571016/diff/1/content/renderer/pepper/peppe...
content/renderer/pepper/pepper_graphics_2d_host.cc:45: // Unbind from the
instance when destoryed if we're still bound.
sp destroyed

Expand Messages | Collapse Messages