Lazy load chrome.* APIs

chrome/renderer/extensions/chrome_v8_context.cc

Index: chrome/renderer/extensions/chrome_v8_context.cc
diff --git a/chrome/renderer/extensions/chrome_v8_context.cc b/chrome/renderer/extensions/chrome_v8_context.cc
index a9c221fefcf9cc587d2997973320b13898b53e50..86754afec63214890626fc39f4d3a74c173c0933 100644
--- a/chrome/renderer/extensions/chrome_v8_context.cc
+++ b/chrome/renderer/extensions/chrome_v8_context.cc
@@ -12,6 +12,7 @@
 #include "chrome/common/extensions/extension.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "chrome/renderer/extensions/chrome_v8_extension.h"
+#include "chrome/renderer/extensions/module_system.h"
 #include "chrome/renderer/extensions/user_script_slave.h"
 #include "content/public/renderer/render_view.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFrame.h"
@@ -23,6 +24,10 @@ namespace extensions {
 namespace {
 
 const char kChromeHidden[] = "chromeHidden";
+const char kUnavailableMessage[] = "You do not have permission to access this "
+                                   "API. Ensure that the required permission "
+                                   "or manifest property is included in your "
+                                   "manifest.json.";
 
 #ifndef NDEBUG
 const char kValidateCallbacks[] = "validateCallbacks";
@@ -39,7 +44,8 @@ ChromeV8Context::ChromeV8Context(v8::Handle<v8::Context> v8_context,
                                                    v8_context)),
       web_frame_(web_frame),
       extension_(extension),
-      context_type_(context_type) {
+      context_type_(context_type),
+      available_extension_apis_initialized_(false) {
   VLOG(1) << "Created context:\n"
           << "  extension id: " << GetExtensionID() << "\n"
           << "  frame:        " << web_frame_ << "\n"
@@ -52,6 +58,10 @@ ChromeV8Context::~ChromeV8Context() {
   v8_context_.Dispose(v8_context_->GetIsolate());
 }
 
+void ChromeV8Context::Invalidate() {
+  module_system_->Invalidate();
+}
+
 std::string ChromeV8Context::GetExtensionID() {
   return extension_ ? extension_->id() : "";
 }
@@ -68,11 +78,11 @@ v8::Handle<v8::Value> ChromeV8Context::GetOrCreateChromeHidden(
     global->SetHiddenValue(v8::String::New(kChromeHidden), hidden);
 
 #ifndef NDEBUG
-    // Tell schema_generated_bindings.js to validate callbacks and events
-    // against their schema definitions.
+    // Tell bindings.js to validate callbacks and events against their schema
+    // definitions.
     v8::Local<v8::Object>::Cast(hidden)->Set(
         v8::String::New(kValidateCallbacks), v8::True());
-    // Tell schema_generated_bindings.js to validate API for ambiguity.
+    // Tell bindings.js to validate API for ambiguity.
     v8::Local<v8::Object>::Cast(hidden)->Set(
         v8::String::New(kValidateAPI), v8::True());
 #endif
@@ -143,15 +153,28 @@ bool ChromeV8Context::CallChromeHiddenMethod(
 }
 
 const std::set<std::string>& ChromeV8Context::GetAvailableExtensionAPIs() {
-  if (!available_extension_apis_.get()) {
+  if (!available_extension_apis_initialized_) {
     available_extension_apis_ =
         ExtensionAPI::GetSharedInstance()->GetAPIsForContext(
             context_type_,
             extension_,
-            UserScriptSlave::GetDataSourceURLForFrame(
-                web_frame_)).Pass();
+            UserScriptSlave::GetDataSourceURLForFrame(web_frame_));
+    available_extension_apis_initialized_ = true;
   }
-  return *(available_extension_apis_.get());
+  return available_extension_apis_;
+}
+
+Feature::Availability ChromeV8Context::GetAvailability(
+    const std::string& api_name) {
+  const std::set<std::string>& available_apis = GetAvailableExtensionAPIs();
+
+  // TODO(cduvall/kalman): Switch to ExtensionAPI::IsAvailable() once Features
+  // are complete.
+  if (available_apis.find(api_name) != available_apis.end())
+    return Feature::CreateAvailability(Feature::IS_AVAILABLE, "");
+
+  return Feature::CreateAvailability(Feature::INVALID_CONTEXT,
+                                     kUnavailableMessage);
 }
 
 void ChromeV8Context::DispatchOnLoadEvent(bool is_incognito_process,