chrome/renderer/extensions/v8_schema_registry.h - Issue 11571014: Lazy load chrome.* APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/v8_schema_registry.h

Issue 11571014: Lazy load chrome.* APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/v8_schema_registry.h

diff --git a/chrome/renderer/extensions/v8_schema_registry.h b/chrome/renderer/extensions/v8_schema_registry.h

index ab3ecf0917a8282e26ecb1b1a722d598ae483b3d..17eb6676e49618e1dc788a0e441da9eb0250d1c1 100644

--- a/chrome/renderer/extensions/v8_schema_registry.h

+++ b/chrome/renderer/extensions/v8_schema_registry.h

@@ -24,10 +24,10 @@ class V8SchemaRegistry {

// Returns a v8::Array with all the schemas for the APIs in |apis|.

v8::Handle<v8::Array> GetSchemas(const std::set<std::string>& apis);

- private:

// Returns a v8::Object for the schema for |api|, possibly from the cache.

v8::Handle<v8::Object> GetSchema(const std::string& api);

+ private:

// Cache of schemas.

typedef std::map<std::string, v8::Persistent<v8::Object> > SchemaCache;

SchemaCache schema_cache_;