chrome/common/extensions/extension.cc - Issue 11571014: Lazy load chrome.* APIs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/extension.cc

Issue 11571014: Lazy load chrome.* APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: addressed comments Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/extensions/extension.cc

diff --git a/chrome/common/extensions/extension.cc b/chrome/common/extensions/extension.cc

index 73c2d524faed6fde21c75e510c223050629e0ac2..1c7c4f65226ae1667d16247482bfa4b39ac460f3 100644

--- a/chrome/common/extensions/extension.cc

+++ b/chrome/common/extensions/extension.cc

@@ -1434,6 +1434,9 @@ bool Extension::InitFromValue(int flags, string16* error) {

api_permissions.insert(APIPermission::kAppWindow);

}

+ if (manifest_->HasKey("devtools_page"))

+ api_permissions.insert(APIPermission::kDevtools);

not at google - send to devlin 2013/02/15 22:26:17 Yeah never mind, we can revert this.

cduvall 2013/02/19 23:58:49 Done.

APIPermissionSet optional_api_permissions;

URLPatternSet optional_host_permissions;

if (!ParsePermissions(keys::kOptionalPermissions,