Lazy load chrome.* APIs

chrome/renderer/extensions/module_system.h

Index: chrome/renderer/extensions/module_system.h
diff --git a/chrome/renderer/extensions/module_system.h b/chrome/renderer/extensions/module_system.h
index be03f2ad225effe5f808e56b520c8a99fd0e6d22..de6392d4ca2809070d7ab46b2f1030a7841cb276 100644
--- a/chrome/renderer/extensions/module_system.h
+++ b/chrome/renderer/extensions/module_system.h
@@ -8,7 +8,7 @@
 #include "base/compiler_specific.h"
 #include "base/memory/linked_ptr.h"
 #include "base/memory/scoped_ptr.h"
-#include "chrome/renderer/extensions/native_handler.h"
+#include "chrome/renderer/extensions/object_backed_native_handler.h"
 #include "v8/include/v8.h"
 
 #include <map>
@@ -17,6 +17,7 @@
 #include <vector>
 
 namespace extensions {
+class ChromeV8Context;
 
 // A module system for JS similar to node.js' require() function.
 // Each module has three variables in the global scope:
@@ -34,7 +35,7 @@ namespace extensions {
 // Note that a ModuleSystem must be used only in conjunction with a single
 // v8::Context.
 // TODO(koz): Rename this to JavaScriptModuleSystem.
-class ModuleSystem : public NativeHandler {
+class ModuleSystem : public ObjectBackedNativeHandler {
  public:
   class SourceMap {
    public:
@@ -61,7 +62,7 @@ class ModuleSystem : public NativeHandler {
   };
 
   // |source_map| is a weak pointer.
-  explicit ModuleSystem(v8::Handle<v8::Context> context, SourceMap* source_map);
+  explicit ModuleSystem(ChromeV8Context* context, SourceMap* source_map);
   virtual ~ModuleSystem();
 
   // Returns true if the current context has a ModuleSystem installed in it.
@@ -69,18 +70,17 @@ class ModuleSystem : public NativeHandler {
 
   // Dumps the debug info from |try_catch| to LOG(ERROR).
   static void DumpException(const v8::TryCatch& try_catch);
+  void LogExceptionToConsole(const v8::TryCatch& try_catch);

[not at google - send to devlin, 2013/02/13 01:45:49]

I think dumping to console also puts to warning. Let's just change DumpException
to do that. Also can be private (see comment in other file...)

[cduvall, 2013/02/15 00:40:28]

Switched this back to how it was since the logging is done in binding.js now.

 
   // Require the specified module. This is the equivalent of calling
   // require('module_name') from the loaded JS files.
-  void Require(const std::string& module_name);
+  v8::Handle<v8::Value> Require(const std::string& module_name);
   v8::Handle<v8::Value> Require(const v8::Arguments& args);
-  v8::Handle<v8::Value> RequireForJs(const v8::Arguments& args);
-  v8::Handle<v8::Value> RequireForJsInner(v8::Handle<v8::String> module_name);
 
   // Calls the specified method exported by the specified module. This is
   // equivalent to calling require('module_name').method_name() from JS.
-  void CallModuleMethod(const std::string& module_name,
-                        const std::string& method_name);
+  v8::Local<v8::Value> CallModuleMethod(const std::string& module_name,
+                                        const std::string& method_name);
 
   // Calls the specified method exported by the specified module. This is
   // equivalent to calling require('module_name').method_name(args) from JS.
@@ -94,6 +94,8 @@ class ModuleSystem : public NativeHandler {
   // |native_handler|.
   void RegisterNativeHandler(const std::string& name,
                              scoped_ptr<NativeHandler> native_handler);
+  // Check if a native handler has been registered for this |name|.
+  bool HasNativeHandler(const std::string& name);
 
   // Causes requireNative(|name|) to look for its module in |source_map_|
   // instead of using a registered native handler. This can be used in unit
@@ -106,6 +108,11 @@ class ModuleSystem : public NativeHandler {
   // Retrieves the lazily defined field specified by |property|.
   static v8::Handle<v8::Value> LazyFieldGetter(v8::Local<v8::String> property,
                                                const v8::AccessorInfo& info);
+  // Retrieves the lazily defined field specified by |property| on a native
+  // object.
+  static v8::Handle<v8::Value> NativeLazyFieldGetter(
+      v8::Local<v8::String> property,
+      const v8::AccessorInfo& info);
 
   // Make |object|.|field| lazily evaluate to the result of
   // require(|module_name|)[|module_field|].
@@ -114,6 +121,13 @@ class ModuleSystem : public NativeHandler {
                     const std::string& module_name,
                     const std::string& module_field);
 
+  // Make |object|.|field| lazily evaluate to the result of
+  // requireNative(|module_name|)[|module_field|].
+  void SetNativeLazyField(v8::Handle<v8::Object> object,
+                          const std::string& field,
+                          const std::string& module_name,
+                          const std::string& module_field);
+
   void set_exception_handler(scoped_ptr<ExceptionHandler> handler) {
     exception_handler_ = handler.Pass();
   }
@@ -124,6 +138,8 @@ class ModuleSystem : public NativeHandler {
   // Called when an exception is thrown but not caught.
   void HandleException(const v8::TryCatch& try_catch);
 
+  static std::string CreateExceptionString(const v8::TryCatch& try_catch);
+
   // Ensure that require_ has been evaluated from require.js.
   void EnsureRequireLoaded();
 
@@ -132,6 +148,25 @@ class ModuleSystem : public NativeHandler {
   v8::Handle<v8::Value> RunString(v8::Handle<v8::String> code,
                                   v8::Handle<v8::String> name);
 
+  v8::Handle<v8::Value> RequireForJs(const v8::Arguments& args);
+  v8::Handle<v8::Value> RequireForJsInner(v8::Handle<v8::String> module_name);
+
+  // Sets a lazy field using the specified |getter|.
+  void SetLazyField(v8::Handle<v8::Object> object,
+                    const std::string& field,
+                    const std::string& module_name,
+                    const std::string& module_field,
+                    v8::AccessorGetter getter);
+
+  typedef v8::Handle<v8::Value> (ModuleSystem::*GetModuleFunc)(
+      const std::string&);
+  // Base implementation of a LazyFieldGetter that can be customized by passing
+  // in a |get_module| function.
+  static v8::Handle<v8::Value> LazyFieldGetterInner(
+      v8::Local<v8::String> property,
+      const v8::AccessorInfo& info,
+      GetModuleFunc get_module);
+
   // Return the named source file stored in the source map.
   // |args[0]| - the name of a source file in source_map_.
   v8::Handle<v8::Value> GetSource(v8::Handle<v8::String> source_name);
@@ -139,6 +174,7 @@ class ModuleSystem : public NativeHandler {
   // Return an object that contains the native methods defined by the named
   // NativeHandler.
   // |args[0]| - the name of a native handler object.
+  v8::Handle<v8::Value> GetNativeFromString(const std::string& native_name);
   v8::Handle<v8::Value> GetNative(const v8::Arguments& args);
 
   // Wraps |source| in a (function(require, requireNative, exports) {...}).
@@ -148,7 +184,7 @@ class ModuleSystem : public NativeHandler {
   v8::Handle<v8::Value> ThrowException(const std::string& message);
 
   // The context that this ModuleSystem is for.
-  v8::Persistent<v8::Context> context_;
+  ChromeV8Context* context_;
 
   // A map from module names to the JS source for that module. GetSource()
   // performs a lookup on this map.