Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: chrome/renderer/extensions/extension_helper.cc

Issue 11571014: Lazy load chrome.* APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: android compilation Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_helper.cc
diff --git a/chrome/renderer/extensions/extension_helper.cc b/chrome/renderer/extensions/extension_helper.cc
index 6e063ce7289040d60ab760819c56a34ad6f22f7e..0e50e8a2b1893f0244fe2675d23b0ca32e0e32f9 100644
--- a/chrome/renderer/extensions/extension_helper.cc
+++ b/chrome/renderer/extensions/extension_helper.cc
@@ -510,8 +510,7 @@ void ExtensionHelper::DidDownloadApplicationIcon(ImageResourceFetcher* fetcher,
if (current_size > kMaxIconSize - actual_icon_size) {
AddMessageToRootConsole(
content::CONSOLE_MESSAGE_LEVEL_ERROR,
- ASCIIToUTF16("Icons are too large. "
- "Maximum total size for app icons is 128 KB."));
+ "Icons are too large. Maximum total size for app icons is 128 KB.");
return;
}
actual_icon_size += current_size;
@@ -523,6 +522,11 @@ void ExtensionHelper::DidDownloadApplicationIcon(ImageResourceFetcher* fetcher,
}
void ExtensionHelper::AddMessageToRootConsole(ConsoleMessageLevel level,
+ const std::string& message) {
+ AddMessageToRootConsole(level, ASCIIToUTF16(message));
+}
+
+void ExtensionHelper::AddMessageToRootConsole(ConsoleMessageLevel level,
const string16& message) {
if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
WebConsoleMessage::Level target_level = WebConsoleMessage::LevelLog;
« no previous file with comments | « chrome/renderer/extensions/extension_helper.h ('k') | chrome/renderer/extensions/file_browser_handler_custom_bindings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698