Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2064)

Unified Diff: chrome/renderer/resources/extensions/page_actions_custom_bindings.js

Issue 11571014: Lazy load chrome.* APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more progress Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/page_actions_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/page_actions_custom_bindings.js b/chrome/renderer/resources/extensions/page_actions_custom_bindings.js
index d5ec8887bc4253701c00494a654c843c6631b081..ab73fb32ce3a6fe0abf4e8d4079377e67fe21186 100644
--- a/chrome/renderer/resources/extensions/page_actions_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/page_actions_custom_bindings.js
@@ -4,17 +4,18 @@
// Custom bindings for the pageActions API.
+var Bindings = require('schema_binding_generator').Bindings;
+var bindings = new Bindings('pageActions');
+
var pageActionsNatives = requireNative('page_actions');
var GetCurrentPageActions = pageActionsNatives.GetCurrentPageActions;
-var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
-
-chromeHidden.registerCustomHook('pageActions',
- function(bindingsAPI, extensionId) {
+bindings.registerCustomHook(function(bindingsAPI, extensionId) {
var pageActions = GetCurrentPageActions(extensionId);
+ var pageActionsApi = bindingsAPI.compiledApi;
var oldStyleEventName = 'pageActions';
for (var i = 0; i < pageActions.length; ++i) {
// Setup events for each extension_id/page_action_id string we find.
- chrome.pageActions[pageActions[i]] = new chrome.Event(oldStyleEventName);
+ pageActionsApi[pageActions[i]] = new chrome.Event(oldStyleEventName);
}
});

Powered by Google App Engine
This is Rietveld 408576698