Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6170)

Unified Diff: chrome/renderer/resources/extensions/notification_custom_bindings.js

Issue 11571014: Lazy load chrome.* APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: windows interactive_ui_tests fix Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/notification_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/notification_custom_bindings.js b/chrome/renderer/resources/extensions/notification_custom_bindings.js
index b88be0981d705c479fdde0bf4eb372822a7ef31b..0e2cd137aa9cffa0d822ed8139ea22ad2b0794bb 100644
--- a/chrome/renderer/resources/extensions/notification_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/notification_custom_bindings.js
@@ -4,10 +4,12 @@
// Custom bindings for the notification API.
-var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
+var binding = require('binding').Binding.create('experimental.notification');
+
var sendRequest = require('sendRequest').sendRequest;
var imageUtil = require('imageUtil');
var lastError = require('lastError');
+var json = require('json');
function url_getter(context, key) {
var f = function() {
@@ -99,8 +101,8 @@ function genHandle(failure_function) {
return function(id, input_notification_details, callback) {
// TODO(dewittj): Remove this hack. This is used as a way to deep
// copy a complex JSON object.
- var notification_details = JSON.parse(
- JSON.stringify(input_notification_details));
+ var notification_details = json.parse(
+ json.stringify(input_notification_details));
var that = this;
replaceNotificationOptionURLs(notification_details, function(success) {
if (success) {
@@ -124,5 +126,6 @@ var experimentalNotificationCustomHook = function(bindingsAPI, extensionId) {
apiFunctions.setHandleRequest('update', handleCreate);
};
-chromeHidden.registerCustomHook('experimental.notification',
- experimentalNotificationCustomHook);
+binding.registerCustomHook(experimentalNotificationCustomHook);
+
+exports.binding = binding.generate();

Powered by Google App Engine
This is Rietveld 408576698