Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: chrome/renderer/extensions/send_request_natives.cc

Issue 11571014: Lazy load chrome.* APIs (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: windows interactive_ui_tests fix Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/send_request_natives.cc
diff --git a/chrome/renderer/extensions/send_request_natives.cc b/chrome/renderer/extensions/send_request_natives.cc
index b788a8af7a99439ad60b58b3e1726b5c9440a8c7..f0249b15e79fd28cc93ffe3d185d2c68a7d6ef5c 100644
--- a/chrome/renderer/extensions/send_request_natives.cc
+++ b/chrome/renderer/extensions/send_request_natives.cc
@@ -13,8 +13,11 @@ using content::V8ValueConverter;
namespace extensions {
SendRequestNatives::SendRequestNatives(Dispatcher* dispatcher,
- RequestSender* request_sender)
- : ChromeV8Extension(dispatcher), request_sender_(request_sender) {
+ RequestSender* request_sender,
+ ChromeV8Context* context)
+ : ChromeV8Extension(dispatcher, context->v8_context()),
+ request_sender_(request_sender),
+ context_(context) {
RouteFunction("GetNextRequestId",
base::Bind(&SendRequestNatives::GetNextRequestId,
base::Unretained(this)));
@@ -42,21 +45,21 @@ v8::Handle<v8::Value> SendRequestNatives::StartRequest(
scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
// See http://crbug.com/149880. The context menus APIs relies on this, but
- // we shouln't really be doing it (e.g. for the sake of the storage API).
+ // we shouldn't really be doing it (e.g. for the sake of the storage API).
converter->SetFunctionAllowed(true);
if (!preserve_null_in_objects)
converter->SetStripNullFromObjects(true);
- scoped_ptr<Value> value_args(
- converter->FromV8Value(args[1], v8::Context::GetCurrent()));
+ scoped_ptr<Value> value_args(converter->FromV8Value(args[1], v8_context()));
if (!value_args.get() || !value_args->IsType(Value::TYPE_LIST)) {
NOTREACHED() << "Unable to convert args passed to StartRequest";
return v8::Undefined();
}
- request_sender_->StartRequest(name, request_id, has_callback, for_io_thread,
- static_cast<ListValue*>(value_args.get()));
+ request_sender_->StartRequest(
+ context_, name, request_id, has_callback, for_io_thread,
+ static_cast<ListValue*>(value_args.get()));
return v8::Undefined();
}

Powered by Google App Engine
This is Rietveld 408576698